Extract buttons from pages so the animation does not affect them #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
enh/fix-buttons-transition
branch
from
58b5988 to
5383a3c
Compare
marcoambrosini
force-pushed
the
enh/fix-buttons-transition
branch
from
5383a3c to
98deda9
Compare
Member
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
enh/fix-buttons-transition
branch
from
98deda9 to
e143d8f
Compare
szaimen
approved these changes
Nov 9, 2023
Collaborator
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM but didnt test and conflicts
szaimen
reviewed
Nov 9, 2023
src/App.vue
Outdated
| mode="out-in"> | ||
| <Page1 v-if="page === 1" @next="goToNextPage" /> | ||
| <Page2 v-else-if="page === 2" @next="goToNextPage" /> | ||
| <Page3 v-else-if="page === 3" @close="close" /> |
Collaborator
There was a problem hiding this comment.
Peobably you dont need to catch the emits anymore?
Signed-off-by Marco <[email protected]>
marcoambrosini
force-pushed
the
enh/fix-buttons-transition
branch
from
bd40b7f to
f3aa00d
Compare
Member
Author
|
/compile amend / |
Collaborator
|
/compile amend / |
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
szaimen
added a commit
that referenced
this pull request
Nov 15, 2023
…hem #993" Signed-off-by: Simon L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by Marco [email protected]
Screen.Recording.2023-11-09.at.09.45.12.mov