Skip to content

Conversation

@Chartman123
Copy link
Collaborator

This fixes #1254 by changing bottom-border color from --color-border-dark to --color-text-maxcontrast

Signed-off-by: Christian Hartmann [email protected]

@Chartman123 Chartman123 self-assigned this Jul 29, 2022
@Chartman123 Chartman123 added the 2. developing Work in progress label Jul 29, 2022
Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 31, 2022
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, although I’m not sure if it really counts as fixing the reported issue, as it’s still not soo visible.

We could merge this as it’s definitely an improvement, and then use the TextInput component as soon as it’s done? We probably need to see how it looks like e.g. when you have multiple fields below each other like for a multiselect or radio options, cause there could be too many borders floating around. cc @marcoambrosini to keep in mind maybe?

@marcoambrosini
Copy link
Member

marcoambrosini commented Aug 1, 2022

I'll add this style to the textField component in a follow-up

@Chartman123
Copy link
Collaborator Author

Much better, although I’m not sure if it really counts as fixing the reported issue, as it’s still not soo visible.

@jancborchardt We could also set the border size to 2px instead of just one. That makes the line much more visible.

@Chartman123 Chartman123 merged commit 810e948 into master Aug 4, 2022
@Chartman123 Chartman123 deleted the fix/visibility branch August 4, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separator line is barely visible due to low contrast

5 participants