Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Add confirmation button to share input #326

Merged
MorrisJobke merged 14 commits into from
Apr 4, 2018
Merged

Add confirmation button to share input #326

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cb61a6b
Replace information icon with confirmation button in share input
jancborchardt Nov 16, 2017
7504926
Extract code to get suggestions to its own method
danxuliu Mar 22, 2018
d003793
Use "showTemporary" instead of explicitly hiding the notification
danxuliu Mar 22, 2018
54306a3
Show an error when getting the suggestions succeeds with failure content
danxuliu Mar 22, 2018
509e60d
Extract code to filter suggestions to its own function
danxuliu Mar 23, 2018
b47e809
Return also exact matches besides all suggestions
danxuliu Mar 23, 2018
79a8192
Extract code to get the permissions to its own method
danxuliu Mar 23, 2018
f422262
Trigger autocompletion when the input field is focused
danxuliu Mar 23, 2018
8c1e5c6
Add a share when clicking on the confirm button
danxuliu Mar 23, 2018
ec9a270
Confirm a share also by pressing enter on the input field
danxuliu Mar 26, 2018
c4a46d2
Reuse last suggestions if the same parameters are used
danxuliu Mar 26, 2018
f5c1a45
Discard cached suggestions when adding a share
danxuliu Mar 26, 2018
6eeb230
Extract code to restore the UI after confirming a share
danxuliu Mar 26, 2018
a010c69
Keep showing the working icon while there are pending operations
danxuliu Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use "showTemporary" instead of explicitly hiding the notification 
"OC.Notification.hide" expects the notification to be hidden to be
passed as an argument. As it was being used to show a temporary
notification the combination of "OC.Notification.show" and
"OC.Notification.hide" was replaced by a single call to
"OC.Notification.showTemporary".

The timeout could have been specified in the options of the call, but it
was left to the default value (7 seconds) for consistency with other
notifications.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Apr 3, 2018
commit d003793e2a2014fd8a6d53d6c6a455ec9a8454b3
3 changes: 1 addition & 2 deletions js/vendor/nextcloud/share.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,7 @@
}).fail(function () {
$('#dropdown').find('.shareWithLoading').addClass('hidden');
$('#dropdown').find('.shareWithConfirm').removeClass('hidden');
OC.Notification.show(t('gallery', 'An error occurred. Please try again'));
window.setTimeout(OC.Notification.hide, 5000);
OC.Notification.showTemporary(t('gallery', 'An error occurred. Please try again'));
});
},
focus: function (event) {
Expand Down