This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Fix "No results found" tooltip #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no "view" nor "configModel" in a Share of the gallery; configuration parameters are got using "oc_appconfig". Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The "No results found" tooltip is now removed when the input field is cleared. This unifies its behaviour with the one used in the server, but it does not address its problems (for example, if a search is started and while it is being performed the input field is cleared the tooltip would be still shown once the search response is received, even if the input field is now empty). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
bug
skjnldsv
approved these changes
Mar 23, 2018
This was referenced Mar 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the No results found tooltip not being shown. It also adds the code needed to hide it based on the one used in the server.
Note, however, that is does not address the problems with that code (for example, if a search is started and while it is being performed the input field is cleared the tooltip would be still shown once the search response is received, even if the input field is now empty).
Probably not worth a backport, although it should be straightforward to do it.
How to test:
Expected result:
A No results found tooltip is shown for the input field; if the input field is emptied the tooltip goes away.
Actual result:
No tooltip is shown.