Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Hide "No results found" tooltip on autocompletion #421

Merged
MorrisJobke merged 1 commit into from
Apr 3, 2018
+5 −0
Merged

Hide "No results found" tooltip on autocompletion #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Hide "No results found" tooltip on autocompletion 
If the tooltip is not explicitly hidden it would still be shown once the
autocompletion dropdown is shown (behind it while it is open, but fully
visible when it is closed).

This unifies its behaviour with the one used in the server, but it does
not address its problems (for example, if a search is started and while
it is being performed the input field is cleared the tooltip would be
still shown once the search response is received, even if the input
field is now empty).

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Mar 26, 2018
commit 6e1998617546aded79bad7feaa2e246eb2188288
5 changes: 5 additions & 0 deletions js/vendor/nextcloud/share.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,10 +340,15 @@
minLength: 2,
delay: 750,
source: function (search, response) {
var $shareWithField = $('#dropdown #shareWith');
var $loading = $('#dropdown .shareWithLoading');
var $remoteInfo = $('#dropdown .shareWithRemoteInfo');
$loading.removeClass('hidden');
$remoteInfo.addClass('hidden');

$shareWithField.removeClass('error')
.tooltip('hide');

$.get(OC.linkToOCS('apps/files_sharing/api/v1') + 'sharees', {
format: 'json',
search: search.term.trim(),
Expand Down