Mock database dependency as it is being pulled in by the CacheWrapper #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with 22 Signed-off-by: Julius Härtl <[email protected]>
PVince81
approved these changes
Jun 17, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 assuming that the DB connection is not touched/relevant for this set of tests
otherwise need to add @group DB at the top of the file
Member
Author
|
Yep the CacheWrapperTest is just testing its internal code with mocks, apart from the constructor there does not seem to be a database dependency there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failed after nextcloud/server#26874 was merged since the CacheWrapper now has a dependency on the database connection which is being pulled in through the server container.
Fixes #1537