restore hook in groupfolders versions
#2260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Linnik <[email protected]>
juliusknorr
reviewed
Feb 6, 2023
| $targetMount->getStorage()->copyFromStorage($versionMount->getStorage(), $versionInternalPath, $targetInternalPath); | ||
| $versionMount->getStorage()->getCache()->copyFromCache($targetCache, $versionCache->get($versionInternalPath), $targetMount->getSourcePath() . '/' . $targetInternalPath); | ||
|
|
||
| \OC_Hook::emit('\OCP\Versions', 'rollback', [ |
Member
There was a problem hiding this comment.
@icewind1991 I'd be curious if that should rather be emitted in the server after the backend method was called?
Merged
4 tasks
Member
|
As nextcloud/server#36690 has been merged can this be closed? |
|
@LinneyS I have tested it on my Nextcloud 26 server running onlyoffice and it seems to fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all
There are reports from users about ONLYOFFICE editors not working properly with opening after restoring a version. The problem repeats only in the group folder. Related to skipping the restore hook.
@juliushaertl
Please see the suggestion for a fix.
Signed-off-by: Sergey Linnik [email protected]