Skip to content

Fix readdir() call in loop with undesirable false evaluation potential #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icewind1991 merged 1 commit into from
Jun 7, 2023
Merged

Fix readdir() call in loop with undesirable false evaluation potential #2416

icewind1991 merged 1 commit into from
Jun 7, 2023

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jun 3, 2023

Fixes a readdir() call within a loop that had undesirable false evaluation potential in:

  • opendir() in OCA\GroupFolders\ACL\ACLStorageWrapper

Same deal as nextcloud/server#38630

Ref: https://www.php.net/manual/en/function.readdir.php

@solracsf solracsf added the 3. to review Items that need to be reviewed label Jun 3, 2023
@icewind1991 icewind1991 merged commit bfa0dfc into nextcloud:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

Assignees

No one assigned

Labels

3. to review Items that need to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshtrichards @icewind1991 @solracsf