refactor(settings): Remove usage of jQuery #3201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
refactor/settings/remove-jquery
branch
from
a67ba40 to
8d94e5f
Compare
artonge
approved these changes
Sep 11, 2024
Member
Author
|
Cypress failure is due to nextcloud/server#47848 (comment). @artonge can you merge or is it too risky to skip cypress? |
susnux
approved these changes
Sep 11, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Nice refactoring, some comments but not about your code 😅
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
refactor/settings/remove-jquery
branch
from
8d94e5f to
55893d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.