Skip to content

Conversation

@provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin added 3. to review Items that need to be reviewed technical debt labels Sep 19, 2024
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the events in the app to check that they are correctly firing and listened to like before?

@provokateurin
Copy link
Member Author

Hehe this even fixes #1932 as the old event just wasn't fired anymore it seems.

@provokateurin provokateurin linked an issue Sep 19, 2024 that may be closed by this pull request
@provokateurin
Copy link
Member Author

Did you test the events in the app to check that they are correctly firing and listened to like before?

Yes, everything working as expected and for the group deletion event it also fixes a bug :)

@provokateurin
Copy link
Member Author

/backport 05c6bcd to stable30

@provokateurin
Copy link
Member Author

/backport 05c6bcd to stable29

@provokateurin
Copy link
Member Author

/backport 05c6bcd to stable28

@provokateurin provokateurin merged commit 48ca2bd into master Sep 19, 2024
@provokateurin provokateurin deleted the refactor/deprecated branch September 19, 2024 19:13
@backportbot
Copy link

backportbot bot commented Sep 19, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/3250/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 05c6bcd2

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3250/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot remove advanced permissions for deleted group

3 participants