Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 20, 2024

Not ready, need to test if my CI adjustments install circles properly for the unit tests.

@provokateurin provokateurin added the 2. developing Items that are currently under development label Sep 20, 2024
@provokateurin provokateurin marked this pull request as ready for review September 20, 2024 13:31
@provokateurin provokateurin added 3. to review Items that need to be reviewed and removed 2. developing Items that are currently under development labels Sep 20, 2024
@provokateurin
Copy link
Member Author

No idea about the oracle tests failing, I didn't even touch those tests or anything related to them 😢

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine apart from failure

@provokateurin
Copy link
Member Author

Failure due to nextcloud/circles#1697 / nextcloud/server#48361

@provokateurin
Copy link
Member Author

Test will pass once nextcloud/circles#1698 is merged.

@provokateurin provokateurin merged commit 6af52c0 into master Oct 1, 2024
@provokateurin provokateurin deleted the test/listeners branch October 1, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants