-
Notifications
You must be signed in to change notification settings - Fork 97
fix(Trash): Fix original location for deleting shared item #3358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb49a13 to
9ff7e62
Compare
a665bb7 to
1276961
Compare
1276961 to
b848516
Compare
b848516 to
5191596
Compare
Signed-off-by: provokateurin <[email protected]>
5191596 to
f7d1505
Compare
|
I'm not sure if there is a more common scenario to trigger this, so that the fix needs to be extended to other storages as well. |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/3358/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f7d1505c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3358/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@provokateurin Thanks for the fix! Would it be possible to also get a backport to stable28? :) |
|
No, unfortunately 28 is no longer supported at all. You should update to at least 29 to still receive security and bug fixes. For some reasons the tests don't pass on 29 and 30, so I'm also not going to fix it on those versions and it will only be in the new 31 version that will be released in less than a month. |
Fixes #3339