fix: prevent duplicate mount points #3752
Conversation
skjnldsv
force-pushed
the
feat/prevent-duplicate-mounts
branch
4 times, most recently
from
495c451 to
335747c
Compare
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/prevent-duplicate-mounts
branch
from
335747c to
b26826c
Compare
|
Do we actually want to do this? there are legitimate use cases for it and blocking it now might break existing workflows |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
feat/prevent-duplicate-mounts
branch
from
aa7960d to
2a06a69
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
feat/prevent-duplicate-mounts
branch
from
2a06a69 to
a41aaa5
Compare
icewind1991
left a comment
icewind1991
left a comment
There was a problem hiding this comment.
I'm predicting the need to add a config flag for this eventually, but for the majority of users this should be an improvement.
| $storageId = $this->getRootFolderStorageId(); | ||
| if ($storageId === null) { | ||
| throw new OCSNotFoundException('Groupfolder not found'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Because psalm isn't smart enough to understand the check above 🤦
There was a problem hiding this comment.
Then you should rather suppress it than bending your code for psalm to be happy (unless your code is actually bad).
There was a problem hiding this comment.
With something like @var ?
There was a problem hiding this comment.
Yeah or just @psalm-supress
There was a problem hiding this comment.
Not sure if really cleaner, but here it is: #3802
Fix https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1012
Partially addresses #681