fix: add orderby to pagination to prevent sorting issues
#3837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable31 |
Member
|
ksort is working, but results in an "unnatural" sorting order, right? I didn't really get that from the PR title and description as it doesn't really explain what is wrong. |
susnux
force-pushed
the
fix/groupfolder-sort
branch
from
902b788 to
f937e86
Compare
Contributor
Author
|
its currently sorted by ID but the frontend is sorted by displayname by default (mount point). |
Contributor
Author
|
BTW no idea whats wrong with psalm, it complains about possible wrong types, but its not possible. |
skjnldsv
approved these changes
Jun 10, 2025
To reproduce: - first create 51 folders like x1, x2... x51 - then after that create one folder like a1 - load page - see x1 - x50 are listed - go to page 2 - see x50 and x51 are listed - go back to page 1 - see that a1 is now listed Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/groupfolder-sort
branch
from
f937e86 to
46cb4ef
Compare
provokateurin
approved these changes
Jun 13, 2025
Member
|
Fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce: