-
Notifications
You must be signed in to change notification settings - Fork 97
fix: scan command not reporting scanned files and folders #3850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Lint failures are not related. Those are up to the maintainers to fix. |
|
/backport to stable31 |
|
/backport to stable30 |
|
Lint failures will be fixed by #3859, so a rebase will be necessary afterwards. |
Signed-off-by: Richard Steinmetz <[email protected]>
a9b742b to
25337d2
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/3850/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 25337d29
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3850/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@st3iny can you do the stable30 backport? |
|
@st3iny can you also add a |
|
@provokateurin I just double checked and it is not broken on |
The scan command did not log scanned files and folders and did not report stats corretly. Now, it does.
Problem: The
::classpath is not starting with a backslash while the event is emitted with a backslash.Ref https://github.com/nextcloud/server/blob/bb4cf2830aca984c001542b3cdc2ebc78bba6941/lib/private/Files/Cache/Scanner.php#L156