Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jun 20, 2025

The scan command did not log scanned files and folders and did not report stats corretly. Now, it does.

Problem: The ::class path is not starting with a backslash while the event is emitted with a backslash.

Ref https://github.com/nextcloud/server/blob/bb4cf2830aca984c001542b3cdc2ebc78bba6941/lib/private/Files/Cache/Scanner.php#L156

@st3iny st3iny self-assigned this Jun 20, 2025
@st3iny st3iny added bug 3. to review Items that need to be reviewed labels Jun 20, 2025
@st3iny
Copy link
Member Author

st3iny commented Jun 20, 2025

Lint failures are not related. Those are up to the maintainers to fix.

@st3iny
Copy link
Member Author

st3iny commented Jun 20, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Jun 20, 2025

/backport to stable30

@provokateurin
Copy link
Member

Lint failures will be fixed by #3859, so a rebase will be necessary afterwards.

@provokateurin provokateurin enabled auto-merge June 23, 2025 08:12
@provokateurin provokateurin merged commit 3692f03 into master Jun 23, 2025
50 checks passed
@provokateurin provokateurin deleted the fix/scan-stats branch June 23, 2025 08:20
@backportbot
Copy link

backportbot bot commented Jun 23, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/3850/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 25337d29

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3850/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member

@st3iny can you do the stable30 backport?

@provokateurin
Copy link
Member

@st3iny can you also add a @noRector for these lines? They were broken by rector refactoring and now rector is trying to change them again.

@st3iny
Copy link
Member Author

st3iny commented Jun 23, 2025

@provokateurin I just double checked and it is not broken on stable30. We are good. Thanks for the other backport :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed backport-request bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

occ groupfolders:scan show always zero in report but work

3 participants