Skip to content

[stable29] fix: don't error in getRelevantPaths if the root of the trash is passed #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 1 commit into from
Jul 25, 2025
Merged

[stable29] fix: don't error in getRelevantPaths if the root of the trash is passed #3898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: don't error in getRelevantPaths if the root of the trash is passed 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991 @szaimen
icewind1991 authored and szaimen committed Jul 25, 2025
commit 913ad185235a18ed7a426f6df7ab8761c0e02aeb
7 changes: 6 additions & 1 deletion lib/ACL/ACLManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,12 @@ private function getRelevantPaths(string $path): array {
$fromTrashbin = str_starts_with($path, '__groupfolders/trash/');
if ($fromTrashbin) {
/* Exploded path will look like ["__groupfolders", "trash", "1", "folderName.d2345678", "rest/of/the/path.txt"] */
[,,$groupFolderId,$rootTrashedItemName] = explode('/', $path, 5);
$parts = explode('/', $path, 5);
if (count($parts) < 4) {
// path is the root of the groupfolder trash
return [];
}
[, , $groupFolderId, $rootTrashedItemName] = $parts;
$groupFolderId = (int)$groupFolderId;
/* Remove the date part */
$separatorPos = strrpos($rootTrashedItemName, '.d');
Expand Down
Loading