-
Notifications
You must be signed in to change notification settings - Fork 97
fix: Ignore groupfolders which have a root_id pointing to nothing #4256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In case the line in the filecache got lost for some reason (the directory was deleted and a scan ran, or a deletion crashed mid-way, or another bug), ignore the groupfolder instead of crashing. We cannot guess the info from filecache anyway. Signed-off-by: Côme Chilliet <[email protected]>
|
backport? |
|
/backport to stable32 |
|
@CarlSchwan right, thanks 🤦 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/4256/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b91f4899
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4256/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/4256/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b91f4899
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4256/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
In case the line in the filecache got lost for some reason (the
directory was deleted and a scan ran, or a deletion crashed mid-way, or
another bug), ignore the groupfolder instead of crashing. We cannot
guess the info from filecache anyway.
We may want to provide repair steps or cli tools to clean DB in this case, but that’s another subject.