Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 12, 2026

In case the line in the filecache got lost for some reason (the
directory was deleted and a scan ran, or a deletion crashed mid-way, or
another bug), ignore the groupfolder instead of crashing. We cannot
guess the info from filecache anyway.

We may want to provide repair steps or cli tools to clean DB in this case, but that’s another subject.

In case the line in the filecache got lost for some reason (the
 directory was deleted and a scan ran, or a deletion crashed mid-way, or
 another bug), ignore the groupfolder instead of crashing. We cannot
 guess the info from filecache anyway.

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc self-assigned this Jan 12, 2026
@come-nc come-nc added the 3. to review Items that need to be reviewed label Jan 12, 2026
@come-nc come-nc merged commit 92b3c3d into master Jan 12, 2026
57 of 59 checks passed
@come-nc come-nc deleted the fix/ignore-broken-groupfolders branch January 12, 2026 10:43
@come-nc come-nc mentioned this pull request Jan 12, 2026
4 tasks
@CarlSchwan
Copy link
Member

backport?

@come-nc
Copy link
Contributor Author

come-nc commented Jan 12, 2026

/backport to stable32

@come-nc
Copy link
Contributor Author

come-nc commented Jan 12, 2026

@CarlSchwan right, thanks 🤦

@come-nc
Copy link
Contributor Author

come-nc commented Jan 12, 2026

/backport to stable31

@backportbot
Copy link

backportbot bot commented Jan 12, 2026

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/4256/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b91f4899

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4256/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@come-nc
Copy link
Contributor Author

come-nc commented Jan 12, 2026

/backport to stable30

@backportbot
Copy link

backportbot bot commented Jan 12, 2026

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/4256/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b91f4899

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4256/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed

Projects

None yet

4 participants