Skip to content

Use new sidebar api to register groupfolders section #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Dec 16, 2019
Merged

Use new sidebar api to register groupfolders section #507

juliusknorr merged 1 commit into from
Dec 16, 2019

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 9, 2019 •
edited
Loading

@juliusknorr juliusknorr mentioned this pull request Jul 9, 2019
Closed
@juliusknorr juliusknorr added 2. developing Items that are currently under development enhancement labels Sep 6, 2019
@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Sep 6, 2019
@skjnldsv skjnldsv mentioned this pull request Oct 9, 2019
Merged
25 tasks
@skjnldsv skjnldsv mentioned this pull request Oct 29, 2019
Closed
14 tasks
@juliusknorr juliusknorr self-assigned this Dec 2, 2019
@juliusknorr juliusknorr force-pushed the enhancement/17-use-sidebar-section-api branch from 9f80199 to 100b178 Compare December 5, 2019 09:44
@juliusknorr juliusknorr added 3. to review Items that need to be reviewed and removed 2. developing Items that are currently under development labels Dec 5, 2019
skjnldsv
skjnldsv reviewed Dec 5, 2019
View reviewed changes
src/files.js
if (fileInfo.mountType !== 'group') {
return
}
return Module.default
Copy link
Member

@skjnldsv skjnldsv Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, dynamic import needs us to specify defaukt ?

Copy link
Member Author

@juliusknorr juliusknorr Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it will return an object with all the exports

@skjnldsv
Copy link
Member

skjnldsv commented Dec 16, 2019

Shall we merge?

@juliusknorr
Copy link
Member Author

juliusknorr commented Dec 16, 2019

Yes, we need to make sure to have a version release just for 18 then

@juliusknorr juliusknorr merged commit e6a87bd into master Dec 16, 2019
@juliusknorr juliusknorr deleted the enhancement/17-use-sidebar-section-api branch December 16, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@juliusknorr juliusknorr

Labels

3. to review Items that need to be reviewed enhancement

Projects

None yet

Milestone

Nextcloud 18

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @skjnldsv