Skip to content

chore: Move to vite #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 3 commits into from
Jun 12, 2024
Merged

chore: Move to vite #1172

Pytal merged 3 commits into from
Jun 12, 2024

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jun 11, 2024 •
edited
Loading

Move building to vite

  • Smoke test

@Pytal Pytal added the 2. developing Work in progress label Jun 11, 2024
@Pytal Pytal self-assigned this Jun 11, 2024
Pytal added 3 commits June 11, 2024 16:29
@Pytal
chore: Move to vite
0d432da 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
refactor: Use addScript
bfb1c3f 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
chore: Update config files
465b825 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 11, 2024
@Pytal Pytal marked this pull request as ready for review June 11, 2024 23:34
@Pytal Pytal requested review from icewind1991 and skjnldsv June 11, 2024 23:34
@Pytal Pytal enabled auto-merge June 11, 2024 23:34
icewind1991
icewind1991 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't explode

@Pytal Pytal merged commit efdb910 into master Jun 12, 2024
@Pytal Pytal deleted the chore/vite branch June 12, 2024 13:09
@skjnldsv skjnldsv mentioned this pull request Oct 22, 2024
Merged
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal @icewind1991