[stable2.4] fix(Sharing): Do not create new share in guest app #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only create the template for share and return the the 'Sharing UI' in the sidebar. Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: fenn-cs <[email protected]>
nfebe
approved these changes
Jun 24, 2024
artonge
reviewed
Jun 25, 2024
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Do we really need to backport this far?
stable2.4 is support 26 max
| <script> | ||
| import { logger } from '../services/logger.ts' | ||
| import { generateOcsUrl } from '@nextcloud/router' | ||
| import { Type as ShareTypes } from '@nextcloud/sharing' |
Contributor
There was a problem hiding this comment.
Might need some adaptation
Contributor
|
Backport should end at 27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1189