fix: Fix navigation manager to be in line with server #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Sep 30, 2024
nickvergessen
commented
- Ref Use NavigationManager instead of AppManager to handle custom apps order server#47523 (comment)
nickvergessen
added
bug
nickvergessen
force-pushed
the
bugfix/noid/fix-navigation-manager
branch
from
927e24d to
3825770
Compare
Member
Author
|
Now failing due to nextcloud/server#48219 And afterwards will break again tomorrow due to nextcloud/server#48454 🙈 @provokateurin can you please take over |
Member
|
Sure, sorry for the mess :/ |
provokateurin
force-pushed
the
bugfix/noid/fix-navigation-manager
branch
from
86d0107 to
1bcb061
Compare
Member
|
Some of the psalm failures I wasn't able to reproduce locally. |
Member
Ok the difference is it reinstalls nextcloud/ocp which pulls in a newer version which then triggers psalm. |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
provokateurin
force-pushed
the
bugfix/noid/fix-navigation-manager
branch
from
1bcb061 to
0a3506d
Compare
Member
|
Waiting for nextcloud/server#48454 before merging this |
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
bugfix/noid/fix-navigation-manager
branch
from
0a3506d to
fe8834e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.