Skip to content

feat: allow limiting guests creation to specific groups #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 3 commits into from
Apr 22, 2025
Merged

feat: allow limiting guests creation to specific groups #1330

susnux merged 3 commits into from
Apr 22, 2025

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 17, 2025 •
edited
Loading

Fix #1314
Fix #1316

  • Base UI
  • Code refactor
  • Make sure we always allow admins
  • Remove the guest creation entry from the sharing suggestions
  • Show proper error in case of creation failure
  • Tests

@skjnldsv skjnldsv self-assigned this Apr 17, 2025
@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress labels Apr 17, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Apr 17, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Apr 17, 2025
@skjnldsv skjnldsv force-pushed the feat/limit-to-groups branch 6 times, most recently from 38bbf2f to 9e58f36 Compare April 18, 2025 12:43
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, come-nc, icewind1991, sorbaugh and susnux and removed request for a team April 18, 2025 13:24
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 18, 2025
@skjnldsv skjnldsv requested a review from Altahrim April 18, 2025 13:25
susnux
susnux reviewed Apr 22, 2025
View reviewed changes
susnux
susnux reviewed Apr 22, 2025
View reviewed changes
susnux
susnux reviewed Apr 22, 2025
View reviewed changes
come-nc
come-nc reviewed Apr 22, 2025
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/limit-to-groups branch from 01a5e3c to dce300c Compare April 22, 2025 15:14
@skjnldsv skjnldsv requested review from come-nc and susnux April 22, 2025 15:15
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 22, 2025

done @susnux @come-nc

@susnux susnux merged commit c08872f into main Apr 22, 2025
45 checks passed
@susnux susnux deleted the feat/limit-to-groups branch April 22, 2025 17:36
@AndyScherzinger AndyScherzinger moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Apr 22, 2025
@skjnldsv skjnldsv mentioned this pull request Jul 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim

@susnux susnux Awaiting requested review from susnux

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews enhancement New feature or request 🍂 2025-Autumn

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Ensure clarity that Guests have no quota (=0) Ability to limit Guest user creation to group / admin

6 participants

@skjnldsv @ArtificialOwl @susnux @come-nc @AndyScherzinger