fix: accept INavigationManager instead of NavigationManager in Filter…

[pulsarf0x]

Description

This pull request updates the constructor of FilteredNavigationManager to accept an INavigationManager interface as its second argument, instead of the concrete NavigationManager class.

This change improves compatibility with proxy or decorated navigation manager implementations (such as custom proxies in other apps), and increases overall flexibility and interoperability.

Context

• Previously, the constructor required a concrete NavigationManager, which caused issues when passing an implementation of INavigationManager (e.g., a proxy or decorator).
• This PR allows any object implementing INavigationManager to be used.

Signed-off-by:
[Your Name] <[email protected]>

[julien-nc]

@skjnldsv How can we solve the Psalm issues?

• The clear method is in OC\NavigationManager but not in OCP\INavigationManager
• The getDefaultEntryIds's signature differs in OC\NavigationManager and OCP\INavigationManager
• Psalm complains about OCA\Guests\Storage\DirMask::isCreatable but it seems fine to me, this class extends OC\Files\Storage\Wrapper\PermissionsMask which has the same method. Removing the string type of the $path param in lib/Storage/DirMask.php line 59 fixes the Psalm issue and possibly the PhpUnit tests

[skjnldsv]

Not a psalm expert unfortunately

[nickvergessen]

How can we solve the Psalm issues?

Add to ignore or type the member to the instance again.

This change improves compatibility with proxy or decorated navigation manager implementations (such as custom proxies in other apps), and increases overall flexibility and interoperability.

@pulsarf0x This is not meant to be implemented. The class here is already an exception. Can you point out other apps that try to do things around the navigation manager replacing the service in the server?

[julien-nc]

• Rebased on main
• Update psalm baseline (using nextcloud/ocp dev-master)

The remaining failures are real. The methods that are not defined in the public interface are not defined in the OC\NavigationManager implementation either.

[pulsarf0x]

Hello team,

I’ve adjusted the Psalm configuration for compatibility with psalm checks for stable30.
Specifically, I re-applied the @psalm-suppress MethodSignatureMismatch annotation on every method that shows up an psalm error on stable30 check like it was already done onthe setDefaultEntryIds() method in a previous commit by another contributor.

Thanks for you help guys.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[pulsarf0x]

Hello,

It looks like the checks that are currently failing are not directly related to my changes, but seem to originate from elsewhere in the codebase.

Please let me know if there’s anything on my side that still needs to be addressed!

Thanks ! :)