fix: add IConfig for AppConfigOverwrite

[kesselb]

Ran into when logging into my local Nextcloud with a guest user:

Could not boot testing: OCA\Guests\AppConfigOverwrite::__construct(): Argument #2 ($config) must be of type OCP\IConfig, OC\Log\PsrLoggerAdapter given, called in /var/www/html/apps-extra/guests/lib/RestrictionManager.php on line 84

IConfig was added as a dependency for AppConfig with nextcloud/server#53449.

[kesselb]

Pinging @ArtificialOwl @nickvergessen @sorbaugh for awareness. AppConfigOverwrite ensures that guest users can only share with other guest users by enforcing a different value for a given config key. With the deprecation of getValue and the recommendation to use getValueBool, getValueString, etc. there might be some adjustments needed over here.

[skjnldsv]

psalm not happy ?

[nickvergessen]

Sounds like you need to split the app, 1 version for 30+31, another one for 32+

[kesselb]

Sounds like you need to split the app, 1 version for 30+31, another one for 32+

I would prefer that.

However if you prefer keeping one version for 30, 31 and 32 we can also add a new class "AppConfigOverwrite32" with a matching constructor and register AppConfigOverwrite for 30, 31 and AppConfigOverwrite32 for 32. Psalm will also not like that 🤣

[nickvergessen]

Splitting is the proper way, but up to https://github.com/nextcloud/guests/blob/main/.github/CODEOWNERS#L3

[skjnldsv]

Split it is 👍

[icewind1991]

#1367 for a solution that doesn't require splitting

[kesselb]

Resolved via #1367