Skip to content

mirror OpenProject notifications to Nextcloud #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
individual-it wants to merge 12 commits into from
Closed

mirror OpenProject notifications to Nextcloud #224

individual-it wants to merge 12 commits into from

Conversation

@individual-it
Copy link
Collaborator

@individual-it individual-it commented Aug 25, 2022 •
edited
Loading

part of https://community.openproject.org/projects/nextcloud-integration/work_packages/42323

All current notifications of OpenProject should be mirrored to Nextcloud.
The view is similar to the notification center in OpenProject where the notifications are aggregated by work-package.
Every time the notifications are fetched again from OpenProject, the Nextcloud notifications are dismissed and recreated according to what is the current status in OpenProject.
The Nextcloud dismiss button has basically no functionality, but through the "Mart as Read" button the user can mark all notifications of that work-package as read and they will not be displayed neither in Nextcloud nor in OpenProject

image

@individual-it individual-it force-pushed the improveNotifications branch 2 times, most recently from f46e359 to 10b4ace Compare September 27, 2022 06:12
individual-it
individual-it commented Oct 11, 2022
View reviewed changes
lib/BackgroundJob/CheckNotifications.php
parent::__construct($time);
// Every 15 minutes
$this->setInterval(60 * 15);
$this->setInterval(10);
Copy link
Collaborator Author

@individual-it individual-it Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be reverted

@wielinde
Copy link
Collaborator

wielinde commented Oct 11, 2022

@individual-it I am sorry to bother you. From the title of the PR I don't get what this is about. Maybe I don't need to know it?

@individual-it
cs fixer
7a73714 
Signed-off-by: Artur Neumann <[email protected]>
@individual-it individual-it changed the title aggregated an more data in the notifications mirror OpenProject notifications to Nextcloud Oct 11, 2022
@github-actions
Copy link

github-actions bot commented Oct 11, 2022

JS Code Coverage

Coverage after merging richNotifications into improveNotifications will be
93.61%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   bootstrap.js0%0%0%0%1, 1–7
   dashboard.js0%0%0%0%1, 1, 10–19, 2, 20–27, 3–9
   fileActions.js0%0%0%0%1, 1, 10–17, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
   utils.js57.45%33.33%50%59.52%10–14, 17–26, 6–9
src/components
   AdminSettings.vue98.98%95.83%77.78%99.84%1, 1, 1
   OAuthConnectButton.vue99.08%80%100%100%1
   PersonalSettings.vue97.81%91.67%71.43%99.39%1, 1
src/components/admin
   FieldValue.vue98.91%90%100%100%1
   FormHeading.vue98.98%75%100%100%1
   TextInput.vue99.18%92.86%85.71%100%1
src/components/icons
   ClippyIcon.vue93.18%50%50%97.50%1, 1
src/components/settings
   CheckBox.vue92.45%80%66.67%97.62%1, 1
   SettingsTitle.vue95.56%50%100%97.62%1, 1
src/components/tab
   EmptyContent.vue99.34%90.91%100%100%1
   SearchInput.vue99.59%83.33%100%100%1
   WorkPackage.vue99.01%33.33%100%99.66%1, 1, 1
src/utils
   workpackageHelper.js97.46%96%100%97.75%17–19
src/views
   Dashboard.vue98.20%50%50%99.63%1, 1, 1
   ProjectsTab.vue99.74%92.31%100%100%23

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

PHP Code Coverage

Coverage after merging richNotifications into improveNotifications will be
62.32%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php20.69%100%25%20%106, 110, 61–62, 65, 72, 74–76, 81–84, 86, 90–95
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php79.43%100%66.67%80.30%111–112, 114, 116–118, 120, 126–127, 129, 319–322, 324–325, 328, 336–340, 362–364, 94
   DirectDownloadController.php0%100%0%0%36–38, 53–55, 57, 60–61
   FilesController.php71.58%100%100%69.66%168, 212, 216, 221–222, 267, 273–277, 281–282, 285, 287, 298–300, 303–304, 306–307, 311–314, 317
   OpenProjectAPIController.php81.13%100%78.57%81.38%132, 167, 184–185, 189, 193, 195–200, 202, 210–211, 214, 216, 218–221, 223–224, 229, 248, 273, 91
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108, 115–116, 118, 120–121, 123–124, 126, 129–130, 132–133, 135, 69–73, 80, 87, 94
lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
lib/Listener
   LoadSidebarScript.php0%100%0%0%100–101, 103–104, 65–70, 72–73, 75–76, 78–79, 85–86, 88, 90, 92–94, 96, 98
lib/Notification
   Notifier.php0%100%0%0%100–101, 103–104, 106–107, 109–114, 116, 120–123, 129–131, 133, 135, 47–50, 60, 69, 80, 82, 85, 87–89, 92, 95, 97, 99
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123–125, 127–128, 130–131, 133–135, 138–139, 141–142, 146–147, 149–151, 157–158, 160, 169, 177–183, 192–197, 206, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   DirectDownloadService.php88%100%100%86.96%65–66, 68
   OauthService.php0%100%0%0%101–105, 115–118, 42–44, 53–59, 61, 70–73, 84–91
   OpenProjectAPIService.php88.93%100%92.31%88.61%190–194, 223–227, 384–385, 387, 399, 407, 411, 432, 520–521, 528, 531–534, 536, 542, 546–548, 720, 791, 822
lib/Settings
   Admin.php0%100%0%0%32–34, 41–43, 46–50, 53, 58–60, 63, 65–66, 68, 72, 76
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php88.89%100%50%93.75%101, 105
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@individual-it
Copy link
Collaborator Author

individual-it commented Oct 11, 2022

@wielinde the description would not helped ether ;-)
This is still WIP, so I wanted to write a better text when finished, but I guess I can do it straight away.

@individual-it individual-it marked this pull request as ready for review October 12, 2022 03:26
@individual-it
Copy link
Collaborator Author

individual-it commented Oct 12, 2022

this needs #205 so the PR is towards improveNotifications
I think as soon #205 is merged we can create a new PR towards master. But still this PR here can be already reviewed

@delete-merged-branch delete-merged-branch bot deleted the branch improveNotifications October 17, 2022 09:55
@individual-it
Copy link
Collaborator Author

individual-it commented Oct 17, 2022

closing in favor of #256

@individual-it individual-it deleted the richNotifications branch October 17, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@individual-it @wielinde