React to notification dismiss

[julien-nc]

I did some digging in the notification implementation in the core and the notifications apps and, good news, we can know when one of our notifications is dismissed.

The IDismissableNotifier interface adds the dismissNotification method to react to notification dismiss.

@individual-it Is this enough to move forward on your side?

[github-actions]

JS Code Coverage

Coverage after merging enh/noid/handle-notification-dismiss into master will be

86.38%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
bootstrap.js	0%	0%	0%	0%	1, 1–7
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–27, 3–9
fileActions.js	0%	0%	0%	0%	1, 1, 10–17, 2–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
utils.js	57.45%	33.33%	50%	59.52%	10–14, 17–26, 6–9
src/components
AdminSettings.vue	99.07%	95.83%	77.78%	99.85%	1, 1, 1
OAuthConnectButton.vue	99.08%	80%	100%	100%	1
PersonalSettings.vue	97.81%	91.67%	71.43%	99.39%	1, 1
src/components/admin
FieldValue.vue	98.91%	90%	100%	100%	1
FormHeading.vue	98.98%	75%	100%	100%	1
TextInput.vue	99.27%	94.12%	87.50%	100%	1
src/components/icons
ClippyIcon.vue	93.18%	50%	50%	97.50%	1, 1
src/components/settings
CheckBox.vue	92.45%	80%	66.67%	97.62%	1, 1
SettingsTitle.vue	95.56%	50%	100%	97.62%	1, 1
src/components/tab
EmptyContent.vue	99.34%	90.91%	100%	100%	1
SearchInput.vue	99.59%	83.33%	100%	100%	1
WorkPackage.vue	99.01%	33.33%	100%	99.66%	1, 1, 1
src/utils
workpackageHelper.js	97.46%	96%	100%	97.75%	17–19
src/views
Dashboard.vue	0%	0%	0%	0%	1, 1, 10, 100–109, 11, 110–119, 12, 120–129, 13, 130–139, 14, 140–149, 15, 150–159, 16, 160–169, 17, 170–179, 18, 180–189, 19, 190–199, 2, 20, 200–209, 21, 210–219, 22, 220–225, 23–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
ProjectsTab.vue	99.74%	92.31%	100%	100%	23

[github-actions]

PHP Code Coverage

Coverage after merging enh/noid/handle-notification-dismiss into master will be

64.15%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/AppInfo
Application.php	20.69%	100%	25%	20%	106, 110, 61–62, 65, 72, 74–76, 81–84, 86, 90–95
lib/BackgroundJob
CheckNotifications.php	0%	100%	0%	0%	48, 50, 52–53, 61–62
lib/Controller
ConfigController.php	79.58%	100%	66.67%	80.45%	112–113, 115, 117–119, 121, 127–128, 130, 320–323, 325–326, 329, 337–341, 363–365, 94
DirectDownloadController.php	0%	100%	0%	0%	36–38, 53–55, 57, 60–61
FilesController.php	71.58%	100%	100%	69.66%	168, 212, 216, 221–222, 267, 273–277, 281–282, 285, 287, 298–300, 303–304, 306–307, 311–314, 317
OpenProjectAPIController.php	89.83%	100%	84.62%	90.24%	136, 171, 188–189, 193, 197, 199–204, 206, 225, 250, 95
lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101, 108, 115–116, 118, 120–121, 123–124, 126, 129–130, 132–133, 135, 69–73, 80, 87, 94
lib/Exception
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
lib/Listener
LoadSidebarScript.php	0%	100%	0%	0%	100–101, 103–104, 65–70, 72–73, 75–76, 78–79, 85–86, 88, 90, 92–94, 96, 98
lib/Notification
Notifier.php	0%	100%	0%	0%	101–105, 110–111, 113, 115, 123–124, 48–51, 61, 70, 81, 83, 86, 88–93, 96, 98
lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	102, 109–110, 113–116, 118–119, 123–125, 127–128, 130–131, 133–135, 138–139, 141–142, 146–147, 149–151, 157–158, 160, 169, 177–183, 192–197, 206, 71–75, 82, 89, 97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
lib/Service
DirectDownloadService.php	88%	100%	100%	86.96%	65–66, 68
OauthService.php	0%	100%	0%	0%	101–105, 115–118, 42–44, 53–59, 61, 70–73, 84–91
OpenProjectAPIService.php	88.11%	100%	92%	87.74%	177–181, 210–214, 368–369, 371, 383, 391, 395, 416, 494–495, 502, 505–508, 510, 516, 520–522, 694, 740, 771
lib/Settings
Admin.php	0%	100%	0%	0%	32–34, 41–43, 46–50, 53, 58–60, 63, 65–66, 68, 72, 76
AdminSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55
Personal.php	88.89%	100%	50%	93.75%	101, 105
PersonalSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55

[individual-it]

wow, that is really great and easy to use, see d56b96f
I will close this PR in favor of #256
Thank you!