Skip to content

[OP#42323] mirror OP notifications to NC notifications #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
individual-it merged 19 commits into from
Nov 9, 2022
Merged

[OP#42323] mirror OP notifications to NC notifications #256

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bae7cef
mirror OP notifications to NC notifications
individual-it Oct 17, 2022
7d0684c
use NC dismiss-notification instead of button to mark notification as…
individual-it Oct 17, 2022
0a9e60c
move link creation to prepare notification function
individual-it Oct 18, 2022
0e57658
use deleteIds to get rid of notifications
individual-it Oct 20, 2022
72f2f20
rename variables
individual-it Oct 21, 2022
cf4af45
fix current tests
individual-it Oct 21, 2022
ada36d3
don't try delete when there are no notifications
individual-it Oct 21, 2022
c40ee7b
use notifications app in CI
individual-it Oct 21, 2022
92ff24e
allow the notifications app to be absent
individual-it Oct 21, 2022
647866e
drop NC 22
individual-it Oct 21, 2022
cade408
set a marker for the time when notifications are checked
individual-it Oct 25, 2022
3907ea6
remember the updatedAt time of any notification associated with a WP
individual-it Oct 25, 2022
fdc873f
Revert "drop NC 22"
individual-it Oct 25, 2022
58a4bc6
fix data validation
individual-it Oct 25, 2022
5950cb8
style fix
individual-it Oct 25, 2022
9f13bc9
fix existing unit tests
individual-it Oct 25, 2022
123f9d2
reset cron interval to 15min
individual-it Oct 25, 2022
ce6f922
fix issue with mark all as read
individual-it Nov 8, 2022
ab46655
more unit tests
individual-it Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename variables 
Signed-off-by: Artur Neumann <[email protected]>
  • Loading branch information
@individual-it
individual-it committed Nov 8, 2022
commit 72f2f207bbe87e7057b2f4210c2eac1b8166b76f
6 changes: 3 additions & 3 deletions lib/Service/OpenProjectAPIService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@ private function checkNotificationsForUser(string $userId): void {
$aggregatedNotifications[$wpId]['actors'][] = $n['_links']['actor']['title'];
}
$manager = $this->notificationManager;
$notification = $manager->createNotification();
$notification->setApp(Application::APP_ID)
$notificationsFilter = $manager->createNotification();
$notificationsFilter->setApp(Application::APP_ID)
->setUser($userId);
$notifications = $this->handler->get($notification);
$notifications = $this->handler->get($notificationsFilter);
$notificationsToDelete = [];
foreach ($notifications as $notificationId => $n) {
$notificationsToDelete[] = $notificationId;
Expand Down