-
Notifications
You must be signed in to change notification settings - Fork 19
[OP#47849]Fix unit test failing on CI #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swikriti Tripathi <[email protected]>
Signed-off-by: Swikriti Tripathi <[email protected]>
a5f5841 to
8244c4d
Compare
8244c4d to
5efb279
Compare
Signed-off-by: Swikriti Tripathi <[email protected]>
5efb279 to
e5d85da
Compare
JS Code CoverageCoverage after merging fix/failing-unit-test into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
individual-it
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related workpackage: [OP#47849] https://community.openproject.org/projects/nextcloud-integration/work_packages/47849/github?query_id=3714
There was some refactoring done in the nextcloud server[master branch] by PR nextcloud/server#37596 that changed some of the function calls so we needed to mock them in the order that they are called to make tests pass. Since these changes were added only to the master (nc-27), other versions need to work with the previous setup. So this PR