CI: Run phpunit test one times more on error #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabim777
force-pushed
the
CI/ErrorMockserverNotServered
branch
from
1fee2ef to
047a8d1
Compare
nabim777
force-pushed
the
CI/ErrorMockserverNotServered
branch
23 times, most recently
from
e131f77 to
8c36a6f
Compare
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
CI/ErrorMockserverNotServered
branch
4 times, most recently
from
e272e9a to
af82260
Compare
nabim777
force-pushed
the
CI/ErrorMockserverNotServered
branch
2 times, most recently
from
3a842e9 to
21fdd9a
Compare
nabim777
force-pushed
the
CI/ErrorMockserverNotServered
branch
from
21fdd9a to
96ae684
Compare
nabim777
changed the title
nabim777
commented
Aug 29, 2024
| if [ "${{matrix.phpVersion}}" -eq 8 ]; then | ||
| make phpunitforphp8.0 | ||
| if [ "${{ matrix.phpVersion }}" -eq 8 ]; then | ||
| make phpunitforphp8.0 || (echo "First attempt failed. Retrying PHPUnit tests..." && make phpunitforphp8.0) |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| make phpunitforphp8.0 || (echo "First attempt failed. Retrying PHPUnit tests..." && make phpunitforphp8.0) | |
| make phpunitforphp8.0 || (echo "First attempt failed. Retrying PHPUnit tests..." && make phpunitforphp8.0) |
If the command before this || fails, the command after this pipe || will be executed.
SagarGi
reviewed
Aug 29, 2024
Contributor
SagarGi
left a comment
SagarGi
left a comment
There was a problem hiding this comment.
If we are gonna retry the unit test only once when some flaky unit test fails then this method would be good instead of creating a separate step using other Github actions 👍
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
CI/ErrorMockserverNotServered
branch
from
96ae684 to
935a27f
Compare
PHP Code CoverageCoverage after merging CI/ErrorMockserverNotServered into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
individual-it
approved these changes
Aug 29, 2024
SagarGi
approved these changes
Aug 29, 2024
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
SagarGi
pushed a commit
that referenced
this pull request
Sep 10, 2024
* retry on the phpunit error for ci Signed-off-by: nabim777 <[email protected]> * use pipeline for retry Signed-off-by: nabim777 <[email protected]> --------- Signed-off-by: nabim777 <[email protected]>
8 tasks
SagarGi
added a commit
that referenced
this pull request
Sep 10, 2024
* Drop support for nc 26 (#689) * Adjust or remove code specific to NC-26 Signed-off-by: Sagar <[email protected]> * Adjust or remove things realted to stable 26 Signed-off-by: Sagar <[email protected]> * fix CI failure Signed-off-by: Sagar <[email protected]> * update changelog Signed-off-by: Sagar <[email protected]> --------- Signed-off-by: Sagar <[email protected]> * Remove version comparision for secret encryption (#695) * Remove version comparision for secret encryption Signed-off-by: Sagar <[email protected]> * stlye fix Signed-off-by: Sagar <[email protected]> --------- Signed-off-by: Sagar <[email protected]> * [WP#56328]Fix error message when upload is restricted by file access control in `Nextcloud` (#688) (#696) * Fix the misleading error message when upload is restricted by file access control app * Added php unit test * update change log --------- Signed-off-by: Sagar <[email protected]> Signed-off-by: nabim777 <[email protected]> Co-authored-by: Sagar Gurung <[email protected]> * [WP#57654]switch encryption for oauth secret (#694) * ci: Reduce testing matrix Signed-off-by: Joas Schilling <[email protected]> * CI: Run phpunit test one times more on error (#687) * retry on the phpunit error for ci Signed-off-by: nabim777 <[email protected]> * use pipeline for retry Signed-off-by: nabim777 <[email protected]> --------- Signed-off-by: nabim777 <[email protected]> --------- Signed-off-by: Sagar <[email protected]> Signed-off-by: nabim777 <[email protected]> Signed-off-by: Joas Schilling <[email protected]> Co-authored-by: Nalem7 <[email protected]> Co-authored-by: Joas Schilling <[email protected]> Co-authored-by: Artur Neumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On CI, there was a flaky error in the PHPUnit test related to the mock server port. So In this PR, there is code added for CI to re-run the phpunit test one time whenever there is an error araised.
Error:
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile