Skip to content

Drop support for nc 26 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SagarGi merged 4 commits into from
Aug 26, 2024
Merged

Drop support for nc 26 #689

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fad6f5
Adjust or remove code specific to NC-26
SagarGi Aug 23, 2024
66dd9f1
Adjust or remove things realted to stable 26
SagarGi Aug 23, 2024
3f1a226
fix CI failure
SagarGi Aug 23, 2024
3170221
update changelog
SagarGi Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust or remove things realted to stable 26 
Signed-off-by: Sagar <[email protected]>
  • Loading branch information
@SagarGi
SagarGi committed Aug 23, 2024
commit 66dd9f172f8f007e9963c403d54d76fac006ca4f
12 changes: 2 additions & 10 deletions .github/workflows/shared_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ jobs:
name: unit tests and linting
strategy:
matrix:
nextcloudVersion: [ stable26, stable27, stable28, stable29, stable30 ]
nextcloudVersion: [ stable27, stable28, stable29, stable30 ]
phpVersion: [ 8.0, 8.1, 8.2, 8.3]
exclude:
- nextcloudVersion: stable26
phpVersion: 8.3
- nextcloudVersion: stable27
phpVersion: 8.3
- nextcloudVersion: stable30
Expand Down Expand Up @@ -180,15 +178,13 @@ jobs:
name: API tests
strategy:
matrix:
nextcloudVersion: [ stable26, stable27, stable28, stable29, stable30 ]
nextcloudVersion: [ stable27, stable28, stable29, stable30 ]
phpVersionMajor: [ 8 ]
phpVersionMinor: [ 0, 1, 2, 3 ]
database: [pgsql, mysql]
isScheduledEventNightly:
- ${{github.event_name == 'schedule'}}
exclude:
- nextcloudVersion: stable26
phpVersionMinor: 3
- nextcloudVersion: stable27
phpVersionMinor: 3
- nextcloudVersion: stable30
Expand Down Expand Up @@ -297,10 +293,6 @@ jobs:
- name: API Tests
env:
NEXTCLOUD_BASE_URL: http://nextcloud
BEHAT_FILTER_TAGS: ${{
matrix.nextcloudVersion == 'stable26' && '~@skipOnStable26' ||
''
}}
run: |
# The following if block can be removed once Nextcloud no longer supports PHP 8.0
if [ "${{matrix.phpVersionMajor}}" -eq 8 ] && [ "${{matrix.phpVersionMinor}}" -eq 0 ]; then
Expand Down
8 changes: 2 additions & 6 deletions tests/acceptance/features/api/setup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,9 +678,7 @@ Feature: setup the integration through an API
When user "OpenProject" sends a "PROPFIND" request to "/remote.php/webdav" using old app password
Then the HTTP status code should be "401"

# to locally run this test the "project folder" needs to be setup already
# issue of group folder https://github.com/nextcloud/groupfolders/issues/2718
@skipOnStable25 @skipOnStable26

Scenario: check version of uploaded file inside a group folder
Given user "Carol" has been created
And user "Carol" has been added to the group "OpenProject"
Expand All @@ -693,9 +691,7 @@ Feature: setup the integration through an API
When user "Carol" deletes folder "/OpenProject/OpenProject/project-demo"
Then the HTTP status code should be 204

# to locally run this test the "project folder" needs to be setup already
# issue of group folder https://github.com/nextcloud/groupfolders/issues/2718
@skipOnStable25 @skipOnStable26

Scenario: check version of uploaded file after an update inside a group folder
Given user "Carol" has been created
And user "Carol" has been added to the group "OpenProject"
Expand Down