Skip to content

Conversation

@saw-jan
Copy link
Collaborator

@saw-jan saw-jan commented Apr 1, 2025

Description

Similar to #806

Related Issue or Workpackage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@saw-jan saw-jan self-assigned this Apr 1, 2025
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

PHP Code Coverage

Coverage after merging test/fix-quota-tests-port into release/2.8 will be
60.54%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%19, 26–35
   ServerVersionHelper.php0%100%0%0%17–18, 21, 24
server/apps/integration_openproject/lib/AppInfo
   Application.php7.41%100%25%6%102, 104–107, 109, 111, 113, 117–120, 122–133, 135, 138, 142, 146–148, 75–77, 80–84, 86–91, 93–94, 97
server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%42, 44–46, 55–56
server/apps/integration_openproject/lib/Controller
   ConfigController.php64.76%100%50%65.37%136, 153–154, 156, 158–160, 162–165, 168–169, 171, 213, 223, 227–229, 293–297, 407–409, 411–413, 418–421, 462, 550–553, 555–556, 559, 567–571, 582, 596–599, 607–608, 612–615, 629–633, 635–636, 638–654, 671–676, 678–679, 681–683, 686, 688–704, 717–724, 726–729, 731–735, 744–749
   DirectDownloadController.php0%100%0%0%37–39, 54–56, 58–65
   DirectUploadController.php70.83%100%100%70%141–143, 186–188, 199, 203–206, 208, 218, 225, 241–243, 245–246, 249–254, 257, 259, 267–269, 275–277, 285–287, 302–304, 323, 328, 334
   FilesController.php72.95%100%83.33%72.41%182–183, 245, 250–253, 255, 257–270, 273–274, 276–277, 281–284, 287, 293
   OpenProjectAPIController.php76.02%100%81.25%75.56%139, 162, 188–191, 194–201, 203–207, 209, 221, 230, 248, 257, 325, 327, 376, 378, 397, 399, 445, 447, 472–475, 478–482, 484, 56, 99
   OpenProjectController.php96.45%100%80%96.95%241–245
server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%102, 109, 116–117, 119, 121–138, 70–74, 81, 88, 95
server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%16
server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php0%100%0%0%48, 56–57, 60–63, 65
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%41–43, 47–50, 52, 54, 57–58, 60, 62–65, 67–70, 72–74
   BeforeUserDeletedListener.php0%100%0%0%48, 55–56, 58–61, 63
   LoadAdditionalScriptsListener.php0%100%0%0%18–19, 21–23, 25
   LoadSidebarScript.php0%100%0%0%100, 102, 104–105, 107, 109, 111, 113–122, 75–91, 96–97, 99
   OpenProjectReferenceListener.php0%100%0%0%54–55, 58–59, 62–63, 65–68
   TermsOfServiceEventListener.php0%100%0%0%59–60, 65–66, 68–69, 71–73, 76–80
   UserChangedListener.php0%100%0%0%52, 59–60, 63–68, 71
server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%47, 57–65, 67–75, 77–79, 81
   Version2310Date20230116153411.php0%100%0%0%46, 49–52, 54–79, 81–82, 84
   Version2400Date20230504144300.php0%100%0%0%47, 57–60
   Version2640Date20240628114301.php0%100%0%0%52, 64–66, 69–70, 73
server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%102, 108–111, 114–116, 119, 123, 157, 165–166, 174, 52, 59, 66, 73–75
server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%103–104, 107–118, 121–122, 124–125, 128–137, 139–143, 66–69, 76, 83, 91, 93, 96
   OpenProjectSearchResultEntry.php100%100%100%100%
server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%100–102, 125–129, 131, 80–93, 95–99
   DirectDownloadService.php88.46%100%100%87.50%66–67, 69
   DirectUploadService.php42.86%100%66.67%40%112, 118, 79–82, 84–92
   OauthService.php32.08%100%40%31.25%104–112, 123–130, 79–87, 89–95
   OpenProjectAPIService.php75.82%100%76.36%75.77%1040–1042, 1044–1046, 1049–1053, 1055–1057, 1066–1069, 1072–1074, 1076, 1079–1084, 1088–1089, 1120–1123, 1142–1149, 1165–1166, 1173–1175, 1177–1180, 1184, 1193, 1211, 1213–1216, 1218–1223, 1365, 1377, 1380, 1400, 1403, 1413–1418, 1543–1545, 1547–1548, 1552–1553, 1555,

Copy link
Collaborator

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit b08364f into release/2.8 Apr 1, 2025
20 checks passed
@saw-jan saw-jan deleted the test/fix-quota-tests-port branch April 1, 2025 10:41
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants