Skip to content

Conversation

@saw-jan
Copy link
Collaborator

@saw-jan saw-jan commented Aug 18, 2025

Description

Method getFoldersForGroup was recently removed in the master branch of groupfolders. See nextcloud/groupfolders#3883
Use the existing alternative method: getFoldersForGroups which returns the same return type and the only difference is that how we provide the group.

- getFoldersForGroup($groupId);
+ getFoldersForGroups([$groupId]);

Compatible with nextcloud:

  • master
  • stable31
  • stable30

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@saw-jan saw-jan force-pushed the fix/alternative-removed-method branch from def8364 to da777cb Compare August 18, 2025 10:26
Copy link
Collaborator

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so now we need to check that nobody is running the old version of the group-folder app

@saw-jan
Copy link
Collaborator Author

saw-jan commented Aug 18, 2025

so now we need to check that nobody is running the old version of the group-folder app

we should be immune to that. using getFoldersForGroups is supported in groupfolder stable28 branch as well.

@saw-jan saw-jan requested a review from individual-it August 18, 2025 10:49
Copy link
Collaborator

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan
Copy link
Collaborator Author

saw-jan commented Aug 19, 2025

so now we need to check that nobody is running the old version of the group-folder app

but there will be a problem if we use the older version of the integration_op app with the new version of the groupfolders app

@saw-jan saw-jan merged commit 22b1ece into master Aug 19, 2025
11 checks passed
@saw-jan saw-jan deleted the fix/alternative-removed-method branch August 19, 2025 04:10
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants