[OP#41127] filter work packages by storage and sort by status

[individual-it]

when searching by query (to link a wp to file):

• don't filter by a magic status id, but by the meta-status "open"
• additionally filter out packages that cannot be linked to the current storage

CC @Kharonus

[kiranparajuli589]

lgtm 👍

[individual-it]

@Kharonus encoding the URL as requested by you. Could you please review the filters

[Kharonus]

@Kharonus encoding the URL as requested by you. Could you please review the filters

The used filters look correct from syntax and semantic. Just one question remains: Should we include now the closed tickets in the search result? And add a sortBy to the request?

[individual-it]

@Kharonus @kiranparajuli589 I've changed it so, that its now does not filter by status at all, but only by the storage and shows results of closed status at the end.
Please review again

[individual-it]

don't undestand why CI is failing, works locally also with newest nextcloud, need to investigate

[individual-it]

CI fails because of this change in NC master nextcloud/server@6be7aa1#diff-cd64d65cb5d9cb2c60c6a050ac0739f4b94390011ef66ee81523885f60a4c64bL63
PR: nextcloud/server#31609

[kiranparajuli589]

very minor comments

[github-actions]

JS Code Coverage

Coverage after merging task/41127-dont-show-workpackage-that-cannot-be-linked-or-have-status-closed-in-the-search into master will be

50.83%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
utils.js	8.33%	0%	0%	14.29%	3–9, 9
src/components
AdminSettings.vue	40.91%	100%	16.67%	50%	73–75, 79, 86–87, 89, 92
OAuthConnectButton.vue	93.10%	100%	85.71%	95.45%	45
PersonalSettings.vue	37.14%	30%	33.33%	42.11%	100–101, 101, 101, 104–105, 105, 105, 108–109, 109, 109, 112, 115–116, 118–119, 119–121, 121, 121, 121–122, 127–128, 128, 128, 133, 139, 87–90, 96–97
src/components/settings
SettingsTitle.vue	0%	100%	0%	0%	14
src/components/tab
EmptyContent.vue	100%	100%	100%	100%
SearchInput.vue	62.22%	50%	64.29%	64.52%	107, 107, 107–108, 110, 114–118, 123, 125–127, 129, 136, 147, 163, 69, 78–81, 88, 88–89, 91, 91–92
WorkPackage.vue	100%	100%	100%	100%
src/utils
workpackageHelper.js	95.12%	95.24%	100%	94.12%	11, 19
src/views
Dashboard.vue	0%	0%	0%	0%	100–101, 101–102, 104, 107, 112, 112, 112–113, 115, 121, 125–126, 134, 137, 141–143, 145, 148–149, 152–153, 153–154, 158–159, 159–160, 162, 164–165, 165, 165, 165, 165–167, 167, 167, 167, 167–169, 172, 177, 177, 177, 179–180, 180, 180–181, 183, 183–185, 189, 193, 196, 196, 196, 199, 199, 199, 204, 207, 207, 207, 214, 217, 217, 217, 222, 222, 222, 227, 227, 227, 23, 232, 235, 238, 24, 241, 241, 241, 244, 244, 244, 247, 25, 250, 253, 26–31, 48, 55, 55, 62, 65–66, 78–79, 79, 79, 82, 85, 85, 85–87, 87, 87–89, 89–90, 92, 95, 95, 95–97, 97, 97–99, 99, 99
ProjectsTab.vue	94.55%	100%	83.33%	94.12%	89–90

[github-actions]

PHP Code Coverage

Coverage after merging task/41127-dont-show-workpackage-that-cannot-be-linked-or-have-status-closed-in-the-search into master will be

51.10%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/AppInfo
Application.php	0%	100%	0%	0%	49, 51–52, 54–55, 59–60, 63, 70, 74–77, 79–84, 95, 99
lib/BackgroundJob
CheckNotifications.php	0%	100%	0%	0%	48, 50, 52–53, 61–62
lib/Controller
ConfigController.php	67.47%	100%	60%	67.95%	101–102, 104, 115–116, 118, 213–216, 218–219, 222, 81–82, 84, 86–88, 90–95
OpenProjectAPIController.php	77.78%	100%	75%	78.13%	164, 181–182, 185, 188, 193, 195–200, 202, 90
lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	106–107, 109–113, 61–64, 71, 78, 85, 92, 99
lib/Exception
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectResponseException.php	0%	100%	0%	0%	16
lib/Listener
LoadSidebarScript.php	0%	100%	0%	0%	59–61, 65–66, 68, 70, 72–74, 76, 78–82
lib/Notification
Notifier.php	0%	100%	0%	0%	100–104, 109–110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92, 95, 97
lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	102, 109–110, 113–116, 118–119, 123–125, 127–128, 130–132, 135–136, 138–139, 143–144, 146–148, 154–155, 157, 166, 174–180, 189–194, 203, 71–75, 82, 89, 97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
lib/Service
OpenProjectAPIService.php	70.71%	100%	72.22%	70.59%	106–107, 116–124, 126–135, 137–138, 141–142, 158–162, 172–173, 175–179, 181, 190–194, 373, 390–391, 393, 408–411, 413, 479–480, 487, 490–493, 495, 501, 505–507, 650
lib/Settings
Admin.php	0%	100%	0%	0%	25–26, 33–35, 37, 42–43, 47, 51
AdminSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55
Personal.php	84%	100%	50%	90.48%	75, 79
PersonalSection.php	0%	100%	0%	0%	19–20, 29, 39, 48, 55