Skip to content

fix: UI colors too light in Nextcloud 32 #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saw-jan merged 6 commits into from
Oct 29, 2025
Merged

fix: UI colors too light in Nextcloud 32 #911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c5b2e3
update nextcloud-vue package
nabim777 Oct 27, 2025
cd6599d
using custom property in css for color
nabim777 Oct 27, 2025
2b26e0d
test: fix l10n mock
saw-jan Oct 29, 2025
dbff78d
test: use shallowMount
saw-jan Oct 29, 2025
b76a0b5
fix the reset button text color
nabim777 Oct 29, 2025
06cf4dd
add change log
nabim777 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use shallowMount 
Signed-off-by: Saw-jan <[email protected]>
  • Loading branch information
@saw-jan @nabim777
saw-jan authored and nabim777 committed Oct 29, 2025
commit dbff78d4d354012c951861b6682ed35d6deaf390
4 changes: 2 additions & 2 deletions tests/jest/components/settings/ErrorNote.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { mount } from '@vue/test-utils'
import { shallowMount } from '@vue/test-utils'

import ErrorNote from '../../../../src/components/settings/ErrorNote.vue'

Expand Down Expand Up @@ -31,7 +31,7 @@ describe('Component: ErrorNote', () => {
})

function getWrapper(propsData = {}) {
return mount(ErrorNote, {
return shallowMount(ErrorNote, {
propsData,
})
}
213 changes: 62 additions & 151 deletions tests/jest/components/settings/__snapshots__/ErrorNote.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,173 +1,84 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Component: ErrorNote should show all provided props 1`] = `
<div
class="notecard note-card notecard--error"
data-v-1362be5a=""
role="alert"
<ncnotecard-stub
class="note-card"
heading=""
text=""
type="error"
>
<span
aria-hidden="true"
class="material-design-icon alert-decagram-icon notecard__icon"
data-v-1362be5a=""
role="img"
<p
class="note-card--title"
>
<svg
class="material-design-icon__svg"
fill="var(--note-theme)"
height="20"
viewBox="0 0 24 24"
width="20"
>
<path
d="M23,12L20.56,9.22L20.9,5.54L17.29,4.72L15.4,1.54L12,3L8.6,1.54L6.71,4.72L3.1,5.53L3.44,9.21L1,12L3.44,14.78L3.1,18.47L6.71,19.29L8.6,22.47L12,21L15.4,22.46L17.29,19.28L20.9,18.46L20.56,14.78L23,12M13,17H11V15H13V17M13,13H11V7H13V13Z"
>
<!---->
</path>
</svg>
</span>
<div
data-v-1362be5a=""
<b>
Test error
</b>
</p>

<p
class="note-card--error-description"
>
<!---->
<p
class="note-card--title"
data-v-1362be5a=""
>
<b
data-v-1362be5a=""
>
Test error
</b>
</p>

<p
class="note-card--error-description"
data-v-1362be5a=""
<span>
Test error message.
</span>
<a
class="link"
href="http://example.com"
target="_blank"
title="Test link"
>
<span
data-v-1362be5a=""
>
Test error message.
</span>
<a
class="link"
data-v-1362be5a=""
href="http://example.com"
target="_blank"
title="Test link"
>
Test link
</a>
</p>
</div>
</div>
Test link
</a>
</p>
</ncnotecard-stub>
`;

exports[`Component: ErrorNote should show error title 1`] = `
<div
class="notecard note-card notecard--error"
data-v-1362be5a=""
role="alert"
<ncnotecard-stub
class="note-card"
heading=""
text=""
type="error"
>
<span
aria-hidden="true"
class="material-design-icon alert-decagram-icon notecard__icon"
data-v-1362be5a=""
role="img"
<p
class="note-card--title"
>
<svg
class="material-design-icon__svg"
fill="var(--note-theme)"
height="20"
viewBox="0 0 24 24"
width="20"
>
<path
d="M23,12L20.56,9.22L20.9,5.54L17.29,4.72L15.4,1.54L12,3L8.6,1.54L6.71,4.72L3.1,5.53L3.44,9.21L1,12L3.44,14.78L3.1,18.47L6.71,19.29L8.6,22.47L12,21L15.4,22.46L17.29,19.28L20.9,18.46L20.56,14.78L23,12M13,17H11V15H13V17M13,13H11V7H13V13Z"
>
<!---->
</path>
</svg>
</span>
<div
data-v-1362be5a=""
<b>
Test error
</b>
</p>

<p
class="note-card--error-description"
>
<!---->
<p
class="note-card--title"
data-v-1362be5a=""
>
<b
data-v-1362be5a=""
>
Test error
</b>
</p>

<p
class="note-card--error-description"
data-v-1362be5a=""
>
<!---->
<!---->
</p>
</div>
</div>
<!---->
</p>
</ncnotecard-stub>
`;

exports[`Component: ErrorNote should show error title and error message 1`] = `
<div
class="notecard note-card notecard--error"
data-v-1362be5a=""
role="alert"
<ncnotecard-stub
class="note-card"
heading=""
text=""
type="error"
>
<span
aria-hidden="true"
class="material-design-icon alert-decagram-icon notecard__icon"
data-v-1362be5a=""
role="img"
<p
class="note-card--title"
>
<svg
class="material-design-icon__svg"
fill="var(--note-theme)"
height="20"
viewBox="0 0 24 24"
width="20"
>
<path
d="M23,12L20.56,9.22L20.9,5.54L17.29,4.72L15.4,1.54L12,3L8.6,1.54L6.71,4.72L3.1,5.53L3.44,9.21L1,12L3.44,14.78L3.1,18.47L6.71,19.29L8.6,22.47L12,21L15.4,22.46L17.29,19.28L20.9,18.46L20.56,14.78L23,12M13,17H11V15H13V17M13,13H11V7H13V13Z"
>
<!---->
</path>
</svg>
</span>
<div
data-v-1362be5a=""
<b>
Test error
</b>
</p>

<p
class="note-card--error-description"
>
<span>
Test error message.
</span>
<!---->
<p
class="note-card--title"
data-v-1362be5a=""
>
<b
data-v-1362be5a=""
>
Test error
</b>
</p>

<p
class="note-card--error-description"
data-v-1362be5a=""
>
<span
data-v-1362be5a=""
>
Test error message.
</span>
<!---->
</p>
</div>
</div>
</p>
</ncnotecard-stub>
`;