chore: set minimium NC version to 30 #36
Conversation
kyteinsky
force-pushed
the
chore/min-nc/30
branch
from
a0efb82 to
b2272f9
Compare
| "post-update-cmd": [ | ||
| "@composer bin all update --ansi", | ||
| "composer dump-autoload" | ||
| ] |
There was a problem hiding this comment.
I think these should probably stay, no?
There was a problem hiding this comment.
I was thinking "forward-command": true does this for us now, but looking at it again, maybe we still need the composer dump-autoload
There was a problem hiding this comment.
No idea. I just know this was required when I added bamarni-bin
There was a problem hiding this comment.
Also, classmap-authoritative should be false, because this can cause updates to fail
There was a problem hiding this comment.
you're right, classmap-authoritative seems to disable classes generated at runtime. This may fail if we do that at a future point in time. (https://getcomposer.org/doc/articles/autoloader-optimization.md#optimization-level-2-a-authoritative-class-maps)
Added the dump-autoload back too. We don't need the fast load times for bamarni-bins since they're all tests but it's a good default.
Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
chore/min-nc/30
branch
from
b2272f9 to
064163c
Compare
PHP 8.0 has been dropped in NC 32 but is required for NC 28.
It may not be worth in the long run to maintain separate GH workflow files to patch the issue and hope that the previous versions are running on PHP >= 8.1.