Skip to content

Conversation

@sualko
Copy link
Member

@sualko sualko commented Feb 7, 2018

@sualko sualko requested a review from LEDfan February 7, 2018 23:21
@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

Merging #88 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     81.15%   81.04%   -0.11%     
  Complexity      275      275              
============================================
  Files            29       29              
  Lines           939      939              
============================================
- Hits            762      761       -1     
- Misses          177      178       +1
Impacted Files Coverage Δ Complexity Δ
lib/newcontentcontainer.php 100% <ø> (ø) 3 <0> (ø) ⬇️
lib/Controller/HttpBindController.php 98.61% <100%> (-1.39%) 26 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ac678...349f2b4. Read the comment docs.

Copy link
Member

@LEDfan LEDfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sualko for taking care, I fixed the logic for checking the types.

I also updated php-cs-fixer to a version which supports PHP 7.2 and run it.

@LEDfan
Copy link
Member

LEDfan commented Feb 8, 2018

@sualko I guess changing the composer.json to use version *.* of phpunit will do the trick to install the correct phpunit version for the PHP version.

@LEDfan
Copy link
Member

LEDfan commented Feb 8, 2018

Already merged inside #86

@LEDfan LEDfan closed this Feb 8, 2018
@LEDfan LEDfan deleted the fix-countable branch February 8, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants