Fix normalizing an exception that wraps a throwable #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
MorrisJobke,
juliusknorr and
nickvergessen
Comment on lines
+315
to
+316
| $t = new TypeError("not a type error"); | ||
| $e = new Exception("an exception", 13, $t); |
Member
There was a problem hiding this comment.
Suggested change
| $t = new TypeError("not a type error"); | |
| $e = new Exception("an exception", 13, $t); | |
| $t = new TypeError('not a type error'); | |
| $e = new Exception('an exception', 13, $t); |
Member
Author
There was a problem hiding this comment.
I want to add the cs fixer later on 😉
nickvergessen
approved these changes
Dec 2, 2020
This was referenced Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normalizer can take nested exceptions. But it fails hard on an exception that contains a previous throwable.
Seen in