Skip to content

fix: Allow older app values to be set #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Dec 14, 2023
Merged

fix: Allow older app values to be set #1075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Allow older app values to be set 
Previously the app value `relativedates` were already used but set to an empty string in case of `false`.
This needs to be handled correctly for users updating from 27 to 28.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Dec 13, 2023
commit 6faf997829ec5eb56a9a3f97ba4499dc9f9a26aa
2 changes: 1 addition & 1 deletion lib/Service/SettingsService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function getDateTimeFormat(): string {
* Load app config if dates should be displayed as relative dates
*/
public function getRelativeDates(): bool {
return json_decode($this->config->getAppValue('logreader', Constants::CONFIG_KEY_RELATIVEDATES, 'false'), flags: JSON_THROW_ON_ERROR);
return json_decode($this->config->getAppValue('logreader', Constants::CONFIG_KEY_RELATIVEDATES, 'false') ?: 'false', flags: JSON_THROW_ON_ERROR);
}

/**
Expand Down