Skip to content

[stable29] refactor: Replace security annotations with respective attributes #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Altahrim merged 2 commits into from
Oct 30, 2024
Merged

[stable29] refactor: Replace security annotations with respective attributes #1386

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab0ffeb
refactor: Replace security annotations with attributes in SettingsCon…
joshtrichards Oct 5, 2024
12504b6
refactor: Replace security annotations with attributes in LogController
joshtrichards Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: Replace security annotations with attributes in SettingsCon… 
…troller

Signed-off-by: Josh <[email protected]>
  • Loading branch information
@joshtrichards @backportbot
joshtrichards authored and backportbot[bot] committed Oct 6, 2024
commit ab0ffeb6f4a23d54c613ebd5558cce6f460c6987
7 changes: 4 additions & 3 deletions lib/Controller/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@

use OCA\LogReader\Constants;
use OCA\LogReader\Service\SettingsService;
use OCA\LogReader\Settings\Admin;
use OCP\AppFramework\ApiController;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\Attribute\AuthorizedAdminSetting;
use OCP\AppFramework\Http\JSONResponse;
use OCP\IConfig;
use OCP\IRequest;
Expand All @@ -49,9 +51,8 @@ public function __construct(

/**
* Get the current app config
*
* @AuthorizedAdminSetting(settings=OCA\LogReader\Settings\Admin)
*/
#[AuthorizedAdminSetting(settings: Admin::class)]
public function getAppConfig(): JSONResponse {
return new JSONResponse($this->settingsService->getAppSettings());
}
Expand All @@ -62,8 +63,8 @@ public function getAppConfig(): JSONResponse {
* @param string $settingsKey AppConfig Key to store
* @param mixed $settingsValues Corresponding AppConfig Value
*
* @AuthorizedAdminSetting(settings=OCA\LogReader\Settings\Admin)
*/
#[AuthorizedAdminSetting(settings: Admin::class)]
public function updateAppConfig(string $settingsKey, $settingsValue): JSONResponse {
$this->logger->debug('Updating AppConfig: {settingsKey} => {settingsValue}', [
'settingsKey' => $settingsKey,
Expand Down