Skip to content

[stable30] fix(LogTable): implement virtual scrolling #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antreesy merged 6 commits into from
Apr 22, 2025
Merged

[stable30] fix(LogTable): implement virtual scrolling #1615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a38e3f1
fix: extend ILogEntry type to include unique id
Antreesy Apr 16, 2025
5b88c1f
fix: hide log entry second-line message unless expanded
Antreesy Apr 16, 2025
dfdd667
fix: implement virtual scrolling
Antreesy Apr 16, 2025
10202e3
fix: adjust styles for IntersectionObserver rows
Antreesy Apr 16, 2025
fe8f471
fix: lint files
Antreesy Apr 16, 2025
4e2fb37
chore(assets): Recompile assets
nextcloud-command Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: extend ILogEntry type to include unique id 
Signed-off-by: Maksim Sukharev <[email protected]>
  • Loading branch information
@Antreesy
Antreesy committed Apr 22, 2025
commit a38e3f189805b8d7c5e10ca9b949d29656fe5a81
4 changes: 2 additions & 2 deletions src/components/table/LogTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
</td>
</tr>

<LogTableRow v-for="row, rowNumber in sortedRows"
:key="rowNumber"
<LogTableRow v-for="row in sortedRows"
:key="row.id"
:row="row"
@show-details="showDetailsForRow" />
</tbody>
Expand Down
2 changes: 2 additions & 0 deletions src/interfaces/ILogEntry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ export type IRawLogEntry = INextcloud14LogEntry | INextcloud22LogEntry
* Fixed version of the log entry where the exception has its own field of type IException
*/
export interface ILogEntry extends Omit<INextcloud22LogEntry, 'exception'> {
/** Unique ID, appended to each iterator element (see LogController#poll) */
id: string
/** Full exception with trace (if applicable) */
exception?: IException
}