Replace deprecated String.prototype.substr() #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
approved these changes
Apr 9, 2022
Member
|
Thanks :) |
Member
|
/compile amend / |
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <[email protected]>
Member
|
The app seems to break recently and this is the only change since 23 I found that could be related at all. Can we revert it? |
nickvergessen
added a commit
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Joas Schilling <[email protected]>
Merged
nextcloud-command
pushed a commit
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nickvergessen
added a commit
that referenced
this pull request
Apr 27, 2022
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
pushed a commit
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Contributor
Author
|
Did the revert fix the issue? I have re-checked the code in this PR and the only thing I could find which could result in a different output with would fix that as well. |
Member
|
The backport is still pending #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.