Integrations tests against nextcloud master are failing when creating a nextcloud user

[kesselb]

Steps to reproduce

1. Run CI
2. Spot an error when creating a nextcloud user

Expected behavior

✅

Actual behavior

❌

Additional info

Something in server changed since yesterday, causing our integration tests to fail.

Last successful run: https://github.com/nextcloud/mail/actions/runs/13292360986 (2025-02-12).

 1) OCA\Mail\Tests\Integration\Db\InternalAddressMapperTest::testIndividualExists
TypeError: OCA\DAV\Events\CardCreatedEvent::__construct(): Argument #2 ($addressBookData) must be of type array, null given, called in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/CardDAV/CardDavBackend.php on line 649

/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/Events/CardCreatedEvent.php:30
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/CardDAV/CardDavBackend.php:649
/home/runner/actions-runner/_work/mail/mail/nextcloud/lib/public/AppFramework/Db/TTransactional.php:45
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/CardDAV/CardDavBackend.php:611
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/CardDAV/SyncService.php:246
/home/runner/actions-runner/_work/mail/mail/nextcloud/lib/public/AppFramework/Db/TTransactional.php:45
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/CardDAV/SyncService.php:241
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/Listener/UserEventsListener.php:73
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/dav/lib/Listener/UserEventsListener.php:51
/home/runner/actions-runner/_work/mail/mail/nextcloud/lib/private/EventDispatcher/ServiceEventListener.php:68
/home/runner/actions-runner/_work/mail/mail/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php:220
/home/runner/actions-runner/_work/mail/mail/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php:56
/home/runner/actions-runner/_work/mail/mail/nextcloud/lib/private/EventDispatcher/EventDispatcher.php:67
/home/runner/actions-runner/_work/mail/mail/nextcloud/lib/private/EventDispatcher/EventDispatcher.php:79
/home/runner/actions-runner/_work/mail/mail/nextcloud/lib/private/User/Manager.php:457
/home/runner/actions-runner/_work/mail/mail/nextcloud/lib/private/User/Manager.php:417
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/vendor-bin/phpunit/vendor/christophwurst/nextcloud_testing/TestUser.php:64
/home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/tests/Integration/Db/InternalAddressMapperTest.php:37

[ChristophWurst]

It's the call to \OC\User\Manager::createUser within a transaction. Some db operations must have changed.

[ChristophWurst]

My CI bisect says that the breakage was introduced with nextcloud/server#50689

[ChristophWurst]

@kesselb do you have the error locally too? The tests pass on my machine …

$ composer run test:integration tests/Integration/Db/InternalAddressMapperTest.php
> phpunit -c tests/phpunit.integration.xml --fail-on-warning 'tests/Integration/Db/InternalAddressMapperTest.php'
PHPUnit 9.6.13 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.15
Configuration: tests/phpunit.integration.xml
Warning:       XDEBUG_MODE=coverage or xdebug.mode=coverage has to be set

........                                                            8 / 8 (100%)

Time: 00:05.666, Memory: 16.00 MB

OK (8 tests, 10 assertions)

[kesselb]

I can reproduce locally when deleting the system address book.

It appears, because the whole integration test is running inside a transaction, that we will never really store the system address book and therefore, later tests cases cannot access it. But a local state in SyncService prevents the test to create the system address again.

1. Delete the system address book
2. Run the integration test
3. 💥
4. OCA\DAV\CardDAV.getLocalSystemAddressBook (comment if (is_null($this->localSystemAddressBook)) { and the closing })
5. Run the integration test
6. ✅

[ChristophWurst]

Fixed upstream by nextcloud/server#51144

Resolved by #10813.