chore: bump psr/log to 3.0.2 #10237
Merged
chore: bump psr/log to 3.0.2 #10237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
st3iny
approved these changes
Oct 9, 2024
vitormattos
added a commit
to vitormattos/mail
that referenced
this pull request
Feb 1, 2025
…y folder Downgrade `psr/log` from 3 to 2 reverting the PR: nextcloud#10237 The file `appinfo/info.xml` of app Mail is using a range of stable versions: ```xml <nextcloud min-version="30" max-version="32" /> ``` At branch `stable30` of `3rdparty` folder of server, is using the versoin 2.0 of `psr/log` https://github.com/nextcloud/3rdparty/blob/stable30/composer.lock#L3296-L3297 ```json "name": "psr/log", "version": "2.0.0", ``` that haven't the :void at interface: https://github.com/nextcloud/3rdparty/blob/stable30/psr/log/src/LoggerAwareTrait.php#L22 ```php public function setLogger(LoggerInterface $logger) ``` Look the code at `psr/log` repository: https://github.com/php-fig/log/blob/2.0.0/src/LoggerAwareTrait.php#L22 ```php public function setLogger(LoggerInterface $logger) ``` But at `composer.json` and at `composer-lock` file of mail, the used version is `3.0.2`: `composer.json` https://github.com/nextcloud/mail/blob/main/composer.json#L41 ```json "psr/log": "^3.0.2", ``` `composer-lock` https://github.com/nextcloud/mail/blob/main/composer.lock#L2274-L2275 ```json "name": "psr/log", "version": "3.0.2", ``` And the signature of method setLogger at version 3.0.2 is: https://github.com/php-fig/log/blob/3.0.2/src/LoggerAwareTrait.php#L18 ```php public function setLogger(LoggerInterface $logger): void ``` The different signature of this interface between `3rdparty` and mail generate error about inconsistent declaration of `Psr\Log\LoggerAwareInterface::setLogger(Psr\Log\LoggerInterface $logger)`. Only is possible upgrade the version of psr/log when the `min-version` at `info.xml` file is equals to 31 because the bump only was made since stable31 of 3rdparty. ref: LibreSign/libresign#4376 ref: LibreSign/libresign#4376 Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
added a commit
to vitormattos/mail
that referenced
this pull request
Feb 1, 2025
…y folder Downgrade `psr/log` from 3 to 2 reverting the PR: nextcloud#10237 The file `appinfo/info.xml` of app Mail is using a range of stable versions: ```xml <nextcloud min-version="30" max-version="32" /> ``` At branch `stable30` of `3rdparty` folder of server, is using the versoin 2.0 of `psr/log` https://github.com/nextcloud/3rdparty/blob/stable30/composer.lock#L3296-L3297 ```json "name": "psr/log", "version": "2.0.0", ``` that haven't the :void at interface: https://github.com/nextcloud/3rdparty/blob/stable30/psr/log/src/LoggerAwareTrait.php#L22 ```php public function setLogger(LoggerInterface $logger) ``` Look the code at `psr/log` repository: https://github.com/php-fig/log/blob/2.0.0/src/LoggerAwareTrait.php#L22 ```php public function setLogger(LoggerInterface $logger) ``` But at `composer.json` and at `composer-lock` file of mail, the used version is `3.0.2`: `composer.json` https://github.com/nextcloud/mail/blob/main/composer.json#L41 ```json "psr/log": "^3.0.2", ``` `composer-lock` https://github.com/nextcloud/mail/blob/main/composer.lock#L2274-L2275 ```json "name": "psr/log", "version": "3.0.2", ``` And the signature of method setLogger at version 3.0.2 is: https://github.com/php-fig/log/blob/3.0.2/src/LoggerAwareTrait.php#L18 ```php public function setLogger(LoggerInterface $logger): void ``` The different signature of this interface between `3rdparty` and mail generate error about inconsistent declaration of `Psr\Log\LoggerAwareInterface::setLogger(Psr\Log\LoggerInterface $logger)`. Only is possible upgrade the version of psr/log when the `min-version` at `info.xml` file is equals to 31 because the version 3.x of `psr/log` only was bumped at stable31 of 3rdparty. ref: LibreSign/libresign#4376 Signed-off-by: Vitor Mattos <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.