Skip to content

[stable3.7] fix: change status code from 404 to 204 for missing avatars #10699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 1 commit into from
Feb 20, 2025
Merged

[stable3.7] fix: change status code from 404 to 204 for missing avatars #10699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: change status code from 404 to 204 for missing avatars 
Switching the response code from 404 to 204 improves compatibility with security appliances like CrowdSec.
Since avatar lookups (including external sources) can validly result in a non-existing avatar.

Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Feb 20, 2025
commit d9f856ca49e632903da710e7d3821dd75e88aaa3
2 changes: 1 addition & 1 deletion lib/Controller/AvatarsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function url(string $email): JSONResponse {
$avatar = $this->avatarService->getAvatar($email, $this->uid);
if (is_null($avatar)) {
// No avatar found
$response = new JSONResponse([], Http::STATUS_NOT_FOUND);
$response = new JSONResponse([], Http::STATUS_NO_CONTENT);

// Debounce this a bit
// (cache for one day)
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Controller/AvatarControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function testGetUrlNoAvatarFound() {

$resp = $this->controller->url($email);

$expected = new JSONResponse([], Http::STATUS_NOT_FOUND);
$expected = new JSONResponse([], Http::STATUS_NO_CONTENT);
$expected->cacheFor(24 * 60 * 60, false, true);
$this->assertEquals($expected, $resp);
}
Expand Down