fix: quota spacing

[GretaD]

The problem:
NcActionText has a br to split action name from action_long text, which breaks our quota and quota text on our action menu as seen below on the screenshot.
NcActionButton has a section for long text that doesnt break: https://github.com/nextcloud-libraries/nextcloud-vue/blob/ae1b3c2ef908985a4052ac03d9a6310593030545/src/components/NcActionButton/NcActionButton.vue#L346-L364

so i used that to fix our problem. Another solution would be if we remove the br and add description prop, but im not sure if that works on every scenario.

before

after

[ChristophWurst]

Works visually until you hover, because buttons have a pointer cursor. This wrongly makes the element appear as if it were clickable.

Can you share more insights about the impact of the br in other usages of the text action? Is the additional space desired everywhere but Mail, or should we fix all usages vi an upstream fix?

Also, the fix only covers the accounts actions. Mailbox actions still have the additional space. Please fix both in one go.

[ChristophWurst]

Another solution would be if we remove the br and add description prop, but im not sure if that works on every scenario.

What would the description prop do?

[GretaD]

Can you share more insights about the impact of the br in other usages of the text action? Is the additional space desired everywhere but Mail, or should we fix all usages vi an upstream fix?

I didnt find any other usage of having a name with a long text, but i feel like im missing something because there is this comment on the ncactiontext component: <!-- white space is shown on longtext, so we can't put {{ text }} on a new line for code readability -->
So, wondering why it was there in the first place, and what can it break if we remove it? So, while wondering, i saw the ncactionbutton change and went with that :).

As i noted on in the ticket, we can also add a desc prop and see how that fits our scenario.

[ChristophWurst]

As i noted on in the ticket, we can also add a desc prop and see how that fits our scenario.

There is no such prop on https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactiontext

[GretaD]

As i noted on in the ticket, we can also add a desc prop and see how that fits our scenario.

There is no such prop on https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactiontext

i know, my proposal is to add a (new) prop.

[ChristophWurst]

I didnt find any other usage of having a name with a long text

Indeed not a lot of those usages.

The usages with name+default slot across our orga are

• https://github.com/nextcloud/spreed/blob/fc2156553dc87f8e46a65262616b3b94ecc562f4/src/components/RightSidebar/Participants/Participant.vue#L114
• https://github.com/nextcloud/spreed/blob/fc2156553dc87f8e46a65262616b3b94ecc562f4/src/components/RightSidebar/Participants/Participant.vue#L114

• mail/src/components/NavigationMailbox.vue

  Line 53 in fc24b57

  <ActionText v-if="!account.isUnified && mailbox.specialRole !== 'flagged'"

• mail/src/components/ThreadEnvelope.vue

  Line 107 in fc24b57

  <NcActionText class="smime-text" :name="smimeHeading">

In other words just Talk and Mail. Is Talk affected by the same design bug?

[ChristophWurst]

i know, my proposal is to add a (new) prop.

Got it. What will the descr prop do?

[GretaD]

In other words just Talk and Mail. Is Talk affected by the same design bug?

Its broken for Talk too.

I found this pr from Maksime and wanted to propose the same for ncactiontext: nextcloud-libraries/nextcloud-vue#6932

[GretaD]

I guess now this is obvious that needs to be changed upstream. So i will do that

[ChristophWurst]

Yep sounds like the best approach if there is not a single use where the current style looks good :)

[ChristophWurst]

I found this pr from Maksime and wanted to propose the same for ncactiontext: nextcloud-libraries/nextcloud-vue#6932

That makes sense if you want to add more text to an existing action. In our case the entry is fully informational and standalone.

[GretaD]

closing. fixing upstream nextcloud-libraries/nextcloud-vue#7116