-
Notifications
You must be signed in to change notification settings - Fork 295
Support PHP 7.3 #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 7.3 #1323
Conversation
|
"Thanks for opening your first pull request in this repository! ✌️" |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This is fixed in Horde 2.6.5. |
|
Ref #1570 |
|
@xf- please update your branch. CI should be green with the latest composer updates. Then we can finally merge this :) |
df87196 to
a469157
Compare
Signed-off-by: Xaver Maierhofer <[email protected]> Signed-off-by: Christoph Wurst <[email protected]>
a469157 to
8f40fe8
Compare
|
🍿 |
|
Can this be backported for NextCloud 15? |
|
Yes, you could backport the horde lib updates. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ChristophWurst I'm sorry, I don't know how the release process is organized here. There are no stable branches, so I created 11.1, but CI is disabled there. |
|
I would suggest to just do it locally. Update the composer dependencies and either just use the git checkout or package a new tarball for your instance. I don't have any plans to make this an official release as we usually don't backport. |
|
@ChristophWurst I'm doing this for nextcloud/docker#706 (review), not for myself ;) |
|
Okay, let me try to find some time this week to do this exceptional backport release. |
|
Could you please open a new ticket? THanks |
|
@ChristophWurst Can the backport-request label be removed? |
|
Yes! |
Uh oh!
There was an error while loading. Please reload this page.