Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 15, 2019

Default accounts will be a bit tricky to handle in the future, as we will often need access to accounts, even if the user is not logged in (background jobs). Moreover, you can't persist any settings as they all share the same -2 id across all users.

Thus, the idea is to just persist them. Admins shall from now on configure this only through the web UI, hence adding a settings interface.

Todo

  • Add admin settings page
  • Add admin provisioning settings
    • Basic settings form
    • Preview for easier template creation
    • Persist settings
    • Update all existing provisioned accounts and create new for all missing
  • Provision new account when user is created
  • When a user accesses a provisioned account, set the (until then) missing password
  • Add repair step to also create these accounts from the old manual config
  • Prevent deletion of the default account

Current (2019-11-15) state

Bildschirmfoto von 2019-11-15 14-31-16

@ChristophWurst ChristophWurst added this to the next milestone Nov 15, 2019
@ChristophWurst ChristophWurst self-assigned this Nov 15, 2019
@ChristophWurst ChristophWurst modified the milestones: next, 0.19.0, 0.20.0 Nov 22, 2019
@ChristophWurst ChristophWurst force-pushed the enhancement/persist-provisioned-account branch 2 times, most recently from 02f1983 to d8fb682 Compare December 3, 2019 12:36
@ChristophWurst ChristophWurst marked this pull request as ready for review December 3, 2019 12:37
@ChristophWurst ChristophWurst force-pushed the enhancement/persist-provisioned-account branch 5 times, most recently from 214ad04 to d12c387 Compare December 3, 2019 18:40
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test. But code looks good

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the enhancement/persist-provisioned-account branch from d12c387 to ad29c8a Compare December 4, 2019 07:49
@ChristophWurst ChristophWurst merged commit fd9bd18 into master Dec 4, 2019
@ChristophWurst ChristophWurst deleted the enhancement/persist-provisioned-account branch December 4, 2019 10:17
@andreas-p
Copy link

Came across this from closing #425 info: I wonder if I under stand the check "When a user accesses a provisioned account, set the (until then) missing password" right: The password for the (formerly called) default account will be stored in the database, just as it is done for quite a while with additional mail accounts?

@ChristophWurst
Copy link
Member Author

Yes, that is correct. For further questions please use https://help.nextcloud.com/c/apps/mail :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants