Skip to content

Set Psalm to error level 4 and update baseline file #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Oct 9, 2020
Merged

Set Psalm to error level 4 and update baseline file #3781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"require": {
"php": ">=7.3",
"arthurhoaro/favicon": "^1.2",
"cerdic/css-tidy": "v1.7.1",
"cerdic/css-tidy": "v1.7.2",
"christophwurst/kitinerary": "^0.2",
"christophwurst/kitinerary-bin": "^0.2",
"christophwurst/kitinerary-flatpak": "^0.2",
Expand Down
12 changes: 6 additions & 6 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0"?>
<psalm
totallyTyped="true"
errorLevel="5"
errorLevel="4"
resolveFromConfigFile="true"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="https://getpsalm.org/schema/config"
Expand Down
119 changes: 111 additions & 8 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,128 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="3.16@d03e5ef057d6adc656c0ff7e166c50b73b4f48f3">
<file src="lib/Controller/AvatarsController.php">
<InvalidArgument occurrences="1">
<code>$avatar</code>
</InvalidArgument>
<file src="lib/Attachment.php">
<MissingDocblockType occurrences="1">
<code>$fetch</code>
</MissingDocblockType>
</file>
<file src="lib/Cache/Cache.php">
<InvalidScalarArgument occurrences="1">
<code>$slice</code>
</InvalidScalarArgument>
<TooManyArguments occurrences="2">
<code>get</code>
<code>get</code>
</TooManyArguments>
</file>
<file src="lib/Db/AliasMapper.php">
<ImplicitToStringCast occurrences="1">
<code>$qb2-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
</ImplicitToStringCast>
</file>
<file src="lib/Db/CollectedAddressMapper.php">
<ImplicitToStringCast occurrences="1">
<code>$qb2-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
</ImplicitToStringCast>
</file>
<file src="lib/Db/MailboxMapper.php">
<ImplicitToStringCast occurrences="1">
<code>$qb2-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
</ImplicitToStringCast>
</file>
<file src="lib/Db/MessageMapper.php">
<ImplicitToStringCast occurrences="44">
<code>$messagesQuery-&gt;createFunction($mailboxesQuery-&gt;getSQL())</code>
<code>$qb-&gt;createFunction($mailboxIdsQuery-&gt;getSQL())</code>
<code>$qb-&gt;createFunction($selectMailboxIds-&gt;getSQL())</code>
<code>$qb-&gt;createFunction($threadRootIdsQuery-&gt;getSQL())</code>
<code>$qb-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($mailboxIds, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getBcc(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getBcc(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getCc(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getCc(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getFrom(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getFrom(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getTo(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($query-&gt;getTo(), IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($uids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($uids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($uids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb1-&gt;createParameter('flag_answered')</code>
<code>$qb1-&gt;createParameter('flag_deleted')</code>
<code>$qb1-&gt;createParameter('flag_draft')</code>
<code>$qb1-&gt;createParameter('flag_flagged')</code>
<code>$qb1-&gt;createParameter('flag_forwarded')</code>
<code>$qb1-&gt;createParameter('flag_important')</code>
<code>$qb1-&gt;createParameter('flag_junk')</code>
<code>$qb1-&gt;createParameter('flag_notjunk')</code>
<code>$qb1-&gt;createParameter('flag_seen')</code>
<code>$qb1-&gt;createParameter('in_reply_to')</code>
<code>$qb1-&gt;createParameter('mailbox_id')</code>
<code>$qb1-&gt;createParameter('message_id')</code>
<code>$qb1-&gt;createParameter('references')</code>
<code>$qb1-&gt;createParameter('sent_at')</code>
<code>$qb1-&gt;createParameter('subject')</code>
<code>$qb1-&gt;createParameter('thread_root_id')</code>
<code>$qb1-&gt;createParameter('uid')</code>
<code>$qb2-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb2-&gt;createNamedParameter(array_keys($indexedMessages), IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb2-&gt;createParameter('email')</code>
<code>$qb2-&gt;createParameter('label')</code>
<code>$qb2-&gt;createParameter('message_id')</code>
<code>$qb2-&gt;createParameter('type')</code>
<code>$qb4-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$query-&gt;createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$query-&gt;createNamedParameter($uids, IQueryBuilder::PARAM_INT_ARRAY)</code>
</ImplicitToStringCast>
</file>
<file src="lib/Db/StatisticsDao.php">
<ImplicitToStringCast occurrences="7">
<code>$qb-&gt;createNamedParameter($emails, IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($emails, IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($emails, IQueryBuilder::PARAM_STR_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($mailboxIds, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($mailboxIds, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($mailboxIds, IQueryBuilder::PARAM_INT_ARRAY)</code>
<code>$qb-&gt;createNamedParameter($mailboxIds, IQueryBuilder::PARAM_INT_ARRAY)</code>
</ImplicitToStringCast>
</file>
<file src="lib/IMAP/MessageMapper.php">
<UndefinedDocblockClass occurrences="1">
<code>$mail-&gt;getRaw()</code>
</UndefinedDocblockClass>
</file>
<file src="lib/IMAP/Sync/Response.php">
<MismatchingDocblockParamType occurrences="2">
<code>IMAPMessage|Message[]</code>
<code>IMAPMessage|Message[]</code>
</MismatchingDocblockParamType>
<MismatchingDocblockReturnType occurrences="2">
<code>IMAPMessage|Message[]</code>
<code>IMAPMessage|Message[]</code>
</MismatchingDocblockReturnType>
</file>
<file src="lib/IMAP/Sync/Synchronizer.php">
<InvalidArgument occurrences="2">
<code>$changedMessages</code>
<code>$newMessages</code>
</InvalidArgument>
</file>
<file src="lib/Listener/AccountSynchronizedThreadUpdaterListener.php">
<MismatchingDocblockReturnType occurrences="1">
<code>DatabaseMessage[]|Generator</code>
</MismatchingDocblockReturnType>
</file>
<file src="lib/Model/IMAPMessage.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="lib/Service/AutoConfig/SmtpConnectivityTester.php">
<UndefinedDocblockClass occurrences="1">
<code>$smtp-&gt;getSMTPObject()</code>
</UndefinedDocblockClass>
<file src="lib/Service/Classification/ImportanceClassifier.php">
<InvalidScalarArgument occurrences="1">
<code>$predictedValidationLabel</code>
</InvalidScalarArgument>
</file>
<file src="lib/Service/HtmlPurify/TransformURLScheme.php">
<NullArgument occurrences="3">
Expand All @@ -39,4 +137,9 @@
<code>$transport</code>
</InvalidArgument>
</file>
<file src="vendor/cerdic/css-tidy/class.csstidy.php">
<InvalidDocblock occurrences="1">
<code>public function parse_string_list($value) {</code>
Copy link
Member Author

@ChristophWurst ChristophWurst Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure why psalm report this, but I sent a PR in any case Cerdic/CSSTidy#61

</InvalidDocblock>
</file>
</files>