Allow adding senders to the address book #4524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request in this repository! ✌️ |
BroCanDo
force-pushed
the
enhancement/4458/add-sender-to-address-book
branch
from
9dd9652 to
d1d5cb1
Compare
BroCanDo
force-pushed
the
enhancement/4458/add-sender-to-address-book
branch
from
930aefb to
ec97269
Compare
Member
|
This looks really good so far. Thanks a lot @BroCanDo! I'll try to test and review soon ✌️ |
Contributor
|
I tested it and all looks good, but design wise maybe we dont need button here: Looks a bit crowded, i would say just text and icon would be fine. |
Author
|
@GretaD something like this? |
BroCanDo
force-pushed
the
enhancement/4458/add-sender-to-address-book
branch
from
4ffcf46 to
3992ca2
Compare
Contributor
|
Looks great. My last nitpick, text when its not hovered, should have the opacity .7, when hovered it should be 1. So its the same everywhere. |
BroCanDo
force-pushed
the
enhancement/4458/add-sender-to-address-book
branch
from
ceb6ad0 to
2b934b6
Compare
GretaD
approved these changes
Feb 24, 2021
miaulalala
reviewed
Mar 2, 2021
BroCanDo
force-pushed
the
enhancement/4458/add-sender-to-address-book
branch
from
41ab2fa to
8f4b3b3
Compare
ChristophWurst
approved these changes
Mar 12, 2021
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Works very well, code looks great :)
closes nextcloud#4458 Signed-off-by: Kristian Lebold <[email protected]> Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/4458/add-sender-to-address-book
branch
from
9987743 to
b3b8743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4458