-
Notifications
You must be signed in to change notification settings - Fork 295
Migrate icons to material design icons #6995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e6286e7 to
14c1cb6
Compare
14c1cb6 to
2e3dce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discovered multiple issues while testing.
NOTE: Some of those issues might be on main too or caused by the nc-vue upgrade to 6.0.0.
1. Send later ActionButtons are jumping on hover
This is most likely caused by the nc-vue upgrade.
Peek.2022-08-16.15-20.webm
2. Attachment modal can't be interacted with and closed
(I'm spamming left click as I hover various elements in the video.)
Peek.2022-08-16.15-29.webm
The close button is not working which resulted in me being stuck and having to force reload the page.
3. Account settings modal can't be closed via the X
However, it can be closed by clicking outside.
4. The account creation modal is missing its form
c147cd2 to
c4defb2
Compare
|
the problems Richard found are fixed. This pr #7060 is needed to move on |
c4defb2 to
8b4d088
Compare
253f93b to
68c7c4b
Compare
Signed-off-by: greta <[email protected]>
68c7c4b to
fd055f3
Compare



Ref nextcloud/groupware#38
To do
there are some bugs because of nc/vue update but not connected to this pr, those bugs can be found here: #7071
test carefully composer(send email, drafts and stuff) and loading envelopes